From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47457)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <don.slutz@gmail.com>) id 1T8JmL-00034Z-Fo
	for qemu-devel@nongnu.org; Sun, 02 Sep 2012 19:40:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <don.slutz@gmail.com>) id 1T8JmK-0002bd-4Z
	for qemu-devel@nongnu.org; Sun, 02 Sep 2012 19:40:33 -0400
Message-ID: <5043EE6B.70509@CloudSwitch.com>
Date: Sun, 02 Sep 2012 19:40:27 -0400
From: Don Slutz <don.slutz@gmail.com>
MIME-Version: 1.0
References: <1346532470-15859-1-git-send-email-Don@CloudSwitch.com>
	<CAAu8pHsbxJrO+rRG8Hs8V9y65gm1RHJ0+UGWjxLapZatvVw5AA@mail.gmail.com>
In-Reply-To: <CAAu8pHsbxJrO+rRG8Hs8V9y65gm1RHJ0+UGWjxLapZatvVw5AA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-i386: Report on error during
	cpu_x86_register().
Reply-To: Don@CloudSwitch.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

Blue Swirl wrote:
> On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz <Don@cloudswitch.com> wrote:
>   
>> Send it to stderr before free of the details.
>>
>> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
>> ---
>>  target-i386/cpu.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index 57c064f..5c0fef1 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
>>      }
>>      object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
>>      if (error_is_set(&error)) {
>> +        fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
>>     
>
> __func__ is preferred by checkpatch.pl and also GCC recommends using it:
> http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
>
>   
>>          error_free(error);
>>          return -1;
>>      }
>> --
>> 1.7.1
>>
>>
>>     
Somehow I forgot to run checkpatch.pl on this.  V2 soon.
   -Don