From: Avi Kivity <avi@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Jan Kiszka <jan.kiszka@web.de>,
Matthew Ogilvie <mmogilvi_qemu@miniinfo.net>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register
Date: Mon, 03 Sep 2012 17:39:09 +0300 [thread overview]
Message-ID: <5044C10D.7050600@redhat.com> (raw)
In-Reply-To: <50446D11.5050904@suse.de>
On 09/03/2012 11:40 AM, Andreas Färber wrote:
> Am 03.09.2012 04:56, schrieb Matthew Ogilvie:
>> diff --git a/hw/i8259_common.c b/hw/i8259_common.c
>> index ab3d98b..dcde5f2 100644
>> --- a/hw/i8259_common.c
>> +++ b/hw/i8259_common.c
> [...]
>> @@ -111,6 +112,7 @@ static const VMStateDescription vmstate_pic_common = {
>> VMSTATE_UINT8(isr, PICCommonState),
>> VMSTATE_UINT8(priority_add, PICCommonState),
>> VMSTATE_UINT8(irq_base, PICCommonState),
>> + VMSTATE_UINT8(icw3, PICCommonState),
>> VMSTATE_UINT8(read_reg_select, PICCommonState),
>> VMSTATE_UINT8(poll, PICCommonState),
>> VMSTATE_UINT8(special_mask, PICCommonState),
>
> Additional VMState needs to be versioned by incrementing .version_id and
> by specifying the new version number here. Otherwise it breaks migration.
And incrementing the version ID breaks backwards migration. The correct
solution is subsections, copying Juan and booking a trip to the Mariana
trench.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-09-03 14:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 2:56 [Qemu-devel] [PATCH v4 0/5] Running Microport UNIX (ca 1987) Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 1/5] fix some debug printf format strings Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 2/5] vl: fix -hdachs/-hda argument order parsing issues Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 3/5] qemu-options.hx: mention retrace= VGA option Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 4/5] vga: add some optional CGA compatibility hacks Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register Matthew Ogilvie
2012-09-03 7:08 ` Paolo Bonzini
2012-09-03 8:40 ` Andreas Färber
2012-09-03 14:39 ` Avi Kivity [this message]
2012-09-03 15:42 ` Juan Quintela
2012-09-03 15:45 ` Jan Kiszka
2012-09-03 15:52 ` Avi Kivity
2012-09-03 15:54 ` Jan Kiszka
2012-09-03 15:57 ` Avi Kivity
2012-09-03 16:02 ` Jan Kiszka
2012-09-03 16:15 ` Avi Kivity
2012-09-03 16:23 ` Paolo Bonzini
2012-09-03 16:30 ` Avi Kivity
2012-09-03 16:33 ` Paolo Bonzini
2012-09-03 16:40 ` Jan Kiszka
2012-09-03 16:56 ` Paolo Bonzini
2012-09-04 8:16 ` Avi Kivity
2012-09-04 9:15 ` Paolo Bonzini
2012-09-04 9:20 ` Avi Kivity
2012-09-04 9:29 ` BALATON Zoltan
2012-09-04 9:37 ` Avi Kivity
2012-09-04 9:51 ` Jan Kiszka
2012-09-04 10:06 ` Paolo Bonzini
2012-09-04 10:44 ` Avi Kivity
2012-09-03 16:30 ` Jan Kiszka
2012-09-03 8:51 ` Jan Kiszka
2012-09-03 8:53 ` Jan Kiszka
2012-09-03 9:34 ` Paolo Bonzini
2012-09-03 10:34 ` Jan Kiszka
2012-09-03 11:11 ` Paolo Bonzini
2012-09-03 11:26 ` Jan Kiszka
2012-09-04 14:29 ` Maciej W. Rozycki
2012-09-04 14:42 ` Paolo Bonzini
2012-09-04 16:01 ` Jan Kiszka
2012-09-04 17:41 ` Maciej W. Rozycki
2012-09-04 17:55 ` Jan Kiszka
2012-09-04 18:27 ` Maciej W. Rozycki
2012-09-04 18:39 ` Jan Kiszka
2012-09-05 4:33 ` Matthew Ogilvie
2012-09-05 15:43 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5044C10D.7050600@redhat.com \
--to=avi@redhat.com \
--cc=afaerber@suse.de \
--cc=jan.kiszka@web.de \
--cc=mmogilvi_qemu@miniinfo.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).