From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1T8XoB-00036h-4y
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 10:39:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1T8Xo4-0003xe-37
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 10:39:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25933)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1T8Xo3-0003ww-Qb
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 10:39:16 -0400
Message-ID: <5044C10D.7050600@redhat.com>
Date: Mon, 03 Sep 2012 17:39:09 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1346640974-30974-1-git-send-email-mmogilvi_qemu@miniinfo.net>
	<1346640974-30974-6-git-send-email-mmogilvi_qemu@miniinfo.net>
	<50446D11.5050904@suse.de>
In-Reply-To: <50446D11.5050904@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking
 slave IRQs with IMR register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Juan Quintela <quintela@redhat.com>, Jan Kiszka <jan.kiszka@web.de>, Matthew Ogilvie <mmogilvi_qemu@miniinfo.net>, qemu-devel@nongnu.org

On 09/03/2012 11:40 AM, Andreas F=E4rber wrote:
> Am 03.09.2012 04:56, schrieb Matthew Ogilvie:
>> diff --git a/hw/i8259_common.c b/hw/i8259_common.c
>> index ab3d98b..dcde5f2 100644
>> --- a/hw/i8259_common.c
>> +++ b/hw/i8259_common.c
> [...]
>> @@ -111,6 +112,7 @@ static const VMStateDescription vmstate_pic_common=
 =3D {
>>          VMSTATE_UINT8(isr, PICCommonState),
>>          VMSTATE_UINT8(priority_add, PICCommonState),
>>          VMSTATE_UINT8(irq_base, PICCommonState),
>> +        VMSTATE_UINT8(icw3, PICCommonState),
>>          VMSTATE_UINT8(read_reg_select, PICCommonState),
>>          VMSTATE_UINT8(poll, PICCommonState),
>>          VMSTATE_UINT8(special_mask, PICCommonState),
>=20
> Additional VMState needs to be versioned by incrementing .version_id an=
d
> by specifying the new version number here. Otherwise it breaks migratio=
n.

And incrementing the version ID breaks backwards migration.  The correct
solution is subsections, copying Juan and booking a trip to the Mariana
trench.


--=20
error compiling committee.c: too many arguments to function