From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jdC-0006Nt-Gc for qemu-devel@nongnu.org; Mon, 03 Sep 2012 23:16:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8jdB-00070R-IW for qemu-devel@nongnu.org; Mon, 03 Sep 2012 23:16:50 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:39275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8jdB-0006zh-0r for qemu-devel@nongnu.org; Mon, 03 Sep 2012 23:16:49 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Sep 2012 13:15:40 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q843Gbne4784154 for ; Tue, 4 Sep 2012 13:16:38 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q843GaKF016551 for ; Tue, 4 Sep 2012 13:16:36 +1000 Message-ID: <50457267.2080806@linux.vnet.ibm.com> Date: Tue, 04 Sep 2012 11:15:51 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1346663926-20188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1346663926-20188-2-git-send-email-xiawenc@linux.vnet.ibm.com> <5044AE18.5030503@redhat.com> In-Reply-To: <5044AE18.5030503@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/6] libqblock APIs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org 于 2012-9-3 21:18, Paolo Bonzini 写道: > Il 03/09/2012 11:18, Wenchao Xia ha scritto: >> 1 QBroker. These structure was used to retrieve errors, every thread must >> create one first, Later maybe thread related staff could be added into it. > > Can you use GError instead? > read through the GError doc, GError is defined as following: struct GError { GQuark domain; gint code; gchar *message; }; I am worried about the message member, I guess program would be aborted if OOM, which I was tring to avoid, so I used char err_msg[1024] in my code, and make things simpler. >> 3 QBlockInfoImageStatic. Now it is not folded with location and format. > > What does "Static" mean? > It is about sorting the information into following kinds: 1) static. It is values that defined at creating time/modifying time, mostly some settings, and it would not be automatically changed in I/O. 2) dynamic. Some information that would changes in I/O and other operations, such as allocated_size, snapshots. 3) statistics. Now only static one is provided, so I added _static suffix. > Paolo > -- Best Regards Wenchao Xia