From: Avi Kivity <avi@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Jan Kiszka" <jan.kiszka@siemens.com>,
"Matthew Ogilvie" <mmogilvi_qemu@miniinfo.net>,
"Andreas Färber" <afaerber@suse.de>,
"quintela@redhat.com" <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register
Date: Tue, 04 Sep 2012 11:16:35 +0300 [thread overview]
Message-ID: <5045B8E3.9070305@redhat.com> (raw)
In-Reply-To: <5044DBEC.4020601@redhat.com>
On 09/03/2012 07:33 PM, Paolo Bonzini wrote:
> Il 03/09/2012 18:30, Avi Kivity ha scritto:
>>>>>> The values above are what every user of the PIC cascaded on our targets
>>>>>> >>> > must program to use them. So We will find them in the state once any
>>>>>> >>> > relevant guest code was able to run (e.g. the BIOS).
>>>>>> >>> >
>>>> >> Suppose the bios has not run yet?
>>> >
>>> > Then you transmit the subsection.
>> And the migration fails. Needlessly, since icw3 == 0 doesn't affect
>> guest operation.
>
> But the point of subsections is to succeed migration in the common case,
> assuming there is more than one case that doesn't affect guest operation.
According to the patch, if icw3 == 4 && !(eclr & 4), then behaviour will
change. With the standard configuration, if two pci interrupts hit at
once, then before the patch irr.2 will be clear, and afterwards set.
So we do have a behavioural change. Is the rest of the code masking
this change under the standard configuration?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-09-04 8:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 2:56 [Qemu-devel] [PATCH v4 0/5] Running Microport UNIX (ca 1987) Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 1/5] fix some debug printf format strings Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 2/5] vl: fix -hdachs/-hda argument order parsing issues Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 3/5] qemu-options.hx: mention retrace= VGA option Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 4/5] vga: add some optional CGA compatibility hacks Matthew Ogilvie
2012-09-03 2:56 ` [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking slave IRQs with IMR register Matthew Ogilvie
2012-09-03 7:08 ` Paolo Bonzini
2012-09-03 8:40 ` Andreas Färber
2012-09-03 14:39 ` Avi Kivity
2012-09-03 15:42 ` Juan Quintela
2012-09-03 15:45 ` Jan Kiszka
2012-09-03 15:52 ` Avi Kivity
2012-09-03 15:54 ` Jan Kiszka
2012-09-03 15:57 ` Avi Kivity
2012-09-03 16:02 ` Jan Kiszka
2012-09-03 16:15 ` Avi Kivity
2012-09-03 16:23 ` Paolo Bonzini
2012-09-03 16:30 ` Avi Kivity
2012-09-03 16:33 ` Paolo Bonzini
2012-09-03 16:40 ` Jan Kiszka
2012-09-03 16:56 ` Paolo Bonzini
2012-09-04 8:16 ` Avi Kivity [this message]
2012-09-04 9:15 ` Paolo Bonzini
2012-09-04 9:20 ` Avi Kivity
2012-09-04 9:29 ` BALATON Zoltan
2012-09-04 9:37 ` Avi Kivity
2012-09-04 9:51 ` Jan Kiszka
2012-09-04 10:06 ` Paolo Bonzini
2012-09-04 10:44 ` Avi Kivity
2012-09-03 16:30 ` Jan Kiszka
2012-09-03 8:51 ` Jan Kiszka
2012-09-03 8:53 ` Jan Kiszka
2012-09-03 9:34 ` Paolo Bonzini
2012-09-03 10:34 ` Jan Kiszka
2012-09-03 11:11 ` Paolo Bonzini
2012-09-03 11:26 ` Jan Kiszka
2012-09-04 14:29 ` Maciej W. Rozycki
2012-09-04 14:42 ` Paolo Bonzini
2012-09-04 16:01 ` Jan Kiszka
2012-09-04 17:41 ` Maciej W. Rozycki
2012-09-04 17:55 ` Jan Kiszka
2012-09-04 18:27 ` Maciej W. Rozycki
2012-09-04 18:39 ` Jan Kiszka
2012-09-05 4:33 ` Matthew Ogilvie
2012-09-05 15:43 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5045B8E3.9070305@redhat.com \
--to=avi@redhat.com \
--cc=afaerber@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=mmogilvi_qemu@miniinfo.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).