From: Gerd Hoffmann <kraxel@redhat.com>
To: Alejandro Martinez Ruiz <alex@securiforest.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers
Date: Tue, 04 Sep 2012 15:30:29 +0200 [thread overview]
Message-ID: <50460275.2020506@redhat.com> (raw)
In-Reply-To: <1346330948-12833-1-git-send-email-alex@securiforest.com>
On 08/30/12 14:49, Alejandro Martinez Ruiz wrote:
> Some xHC drivers (most notably on Windows and BSD systems) read
> the first capability registers using 1 and 2 bytes accesses, since
> this is how they are defined in section 5.3 of the xHCI specs.
>
> Enabling these kind of read accesses allows Windows and FreeBSD
> guests to properly recognize the host controller.
>
> As this is an exception to the general 4-byte aligned accesses rule,
> we special-case the code path for capability reading and implement
> checks to guard against wrong size/alignment combinations.
No need to do that by hand, the memory api can handle it. Can you check
whenever usb-next
(http://www.kraxel.org/cgit/qemu/log/?h=rebase/usb-next) works for you?
thanks,
Gerd
next prev parent reply other threads:[~2012-09-04 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 12:49 [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers Alejandro Martinez Ruiz
2012-09-04 13:30 ` Gerd Hoffmann [this message]
2012-09-06 9:20 ` Alejandro Martinez
2012-09-06 10:15 ` Gerd Hoffmann
2012-09-06 10:42 ` Alejandro Martinez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50460275.2020506@redhat.com \
--to=kraxel@redhat.com \
--cc=alex@securiforest.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).