From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8tDD-000596-Lf for qemu-devel@nongnu.org; Tue, 04 Sep 2012 09:30:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8tD7-0000F8-Pc for qemu-devel@nongnu.org; Tue, 04 Sep 2012 09:30:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8tD7-0000ER-HX for qemu-devel@nongnu.org; Tue, 04 Sep 2012 09:30:33 -0400 Message-ID: <50460275.2020506@redhat.com> Date: Tue, 04 Sep 2012 15:30:29 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1346330948-12833-1-git-send-email-alex@securiforest.com> In-Reply-To: <1346330948-12833-1-git-send-email-alex@securiforest.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alejandro Martinez Ruiz Cc: qemu-devel@nongnu.org On 08/30/12 14:49, Alejandro Martinez Ruiz wrote: > Some xHC drivers (most notably on Windows and BSD systems) read > the first capability registers using 1 and 2 bytes accesses, since > this is how they are defined in section 5.3 of the xHCI specs. > > Enabling these kind of read accesses allows Windows and FreeBSD > guests to properly recognize the host controller. > > As this is an exception to the general 4-byte aligned accesses rule, > we special-case the code path for capability reading and implement > checks to guard against wrong size/alignment combinations. No need to do that by hand, the memory api can handle it. Can you check whenever usb-next (http://www.kraxel.org/cgit/qemu/log/?h=rebase/usb-next) works for you? thanks, Gerd