From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8tVJ-00084I-S5 for qemu-devel@nongnu.org; Tue, 04 Sep 2012 09:49:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8tVI-0006Bj-Ub for qemu-devel@nongnu.org; Tue, 04 Sep 2012 09:49:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8tVI-0006Bd-MH for qemu-devel@nongnu.org; Tue, 04 Sep 2012 09:49:20 -0400 Message-ID: <504606D9.5070709@redhat.com> Date: Tue, 04 Sep 2012 15:49:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1346663926-20188-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1346663926-20188-5-git-send-email-xiawenc@linux.vnet.ibm.com> <5044BE96.7080701@redhat.com> <5044CA2F.8000505@redhat.com> <5045AA90.4050001@linux.vnet.ibm.com> <5045E84C.6030902@redhat.com> In-Reply-To: <5045E84C.6030902@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] libqblock internal used functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com, Wenchao Xia , qemu-devel@nongnu.org Il 04/09/2012 13:38, Eric Blake ha scritto: > Since qemu does not support it now, yes, you can ignore it for now. But > please make sure that you aren't hard-coding it into the API - that is, > make sure that the API can someday grow to support larger sector sizes > with minimal impact to library clients (that is, that new clients aware > of the new API can target larger sector size once qemu has been patched > to support larger sector size). We can support 4k sector disks even if the addressing unit remains 512 bytes, just like in the Linux kernel. Wenchao, you can add a logical_block_size item to the image info and make it always return 512. Paolo