From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33273)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1T8tqv-0001tm-D9
	for qemu-devel@nongnu.org; Tue, 04 Sep 2012 10:11:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1T8tqr-0005Tl-Ij
	for qemu-devel@nongnu.org; Tue, 04 Sep 2012 10:11:41 -0400
Message-ID: <50460C09.8010504@redhat.com>
Date: Tue, 04 Sep 2012 16:11:21 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1346490405-18889-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1346490405-18889-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block/curl: Fix wrong free statement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

Am 01.09.2012 11:06, schrieb Stefan Weil:
> Report from smatch:
> block/curl.c:546 curl_close(21) info: redundant null check on s->url calling free()
> 
> The check was redundant, and free was also wrong because the memory
> was allocated using g_strdup.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Thanks, applied to block-next.

Kevin