From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8u2u-00016R-76 for qemu-devel@nongnu.org; Tue, 04 Sep 2012 10:24:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8u2q-00019b-7E for qemu-devel@nongnu.org; Tue, 04 Sep 2012 10:24:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8u2p-00019V-TK for qemu-devel@nongnu.org; Tue, 04 Sep 2012 10:24:00 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q84ENxMM010567 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Sep 2012 10:23:59 -0400 Message-ID: <50460EFC.7010803@redhat.com> Date: Tue, 04 Sep 2012 16:23:56 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1346434010-14801-1-git-send-email-berrange@redhat.com> <5040F4B9.50509@redhat.com> In-Reply-To: <5040F4B9.50509@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Don't require encryption password for 'qemu-img info' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org Am 31.08.2012 19:30, schrieb Eric Blake: > On 08/31/2012 10:26 AM, Daniel P. Berrange wrote: >> From: "Daniel P. Berrange" >> >> The encryption password is only required if I/O is going to be >> performed on a disk image. The 'qemu-img info' command merely >> reports metadata, so it should not ask for a decryption password >> >> Signed-off-by: Daniel P. Berrange >> --- >> qemu-img.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index b41e670..3dd4ec7 100644 >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -221,7 +221,8 @@ static int print_block_option_help(const char *filename, const char *fmt) >> >> static BlockDriverState *bdrv_new_open(const char *filename, >> const char *fmt, >> - int flags) >> + int flags, >> + int requireIO) > > Since you only pass 0 or 1 for requireIO, why not make it bool? Yes, please. bool require_io, to be precise. The qemu coding style doesn't use camelCase here. > For > that matter, why not make it part of 'flags', where the default is to > require decryption, and a new flag BDV_O_NO_IO can be added when opening > an image for no I/O and used to avoid the decryption? Because the block layer isn't really interested in it, this should be kept inside qemu-img. Kevin