From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54920)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1T8y5I-0002qM-Ku
	for qemu-devel@nongnu.org; Tue, 04 Sep 2012 14:42:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1T8y5H-0007Dd-Bz
	for qemu-devel@nongnu.org; Tue, 04 Sep 2012 14:42:48 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:39285)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1T8y5H-0007DH-1q
	for qemu-devel@nongnu.org; Tue, 04 Sep 2012 14:42:47 -0400
Received: by pbbjt11 with SMTP id jt11so9868665pbb.4
	for <qemu-devel@nongnu.org>; Tue, 04 Sep 2012 11:42:46 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <50464BA2.5070209@twiddle.net>
Date: Tue, 04 Sep 2012 11:42:42 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1346606812.git.blauwirbel@gmail.com>
	<5955be78eb92f05b5fafa58477c543f89afaf39c.1346606812.git.blauwirbel@gmail.com>
In-Reply-To: <5955be78eb92f05b5fafa58477c543f89afaf39c.1346606812.git.blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On 09/02/2012 10:33 AM, Blue Swirl wrote:
> +/* fpu_helper.c */
> +uint32_t set_cc_f32(float32 v1, float32 v2);
> +uint32_t set_cc_f64(float64 v1, float64 v2);
> +uint32_t set_cc_nz_f32(float32 v);
> +uint32_t set_cc_nz_f64(float64 v);
> +

I think that the CC handling should stay together, regardless of FPU-ness.
These functions are quite small and can be usefully inlined by the compiler.

OTOH, this is much easier to do with my translate.c rewrite, so maybe I'll
just take responsibility for moving them back...


r~