From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52787)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1T9AP3-00042w-S2
	for qemu-devel@nongnu.org; Wed, 05 Sep 2012 03:52:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1T9AOz-0001XP-9B
	for qemu-devel@nongnu.org; Wed, 05 Sep 2012 03:52:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17914)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1T9AOz-0001XK-0M
	for qemu-devel@nongnu.org; Wed, 05 Sep 2012 03:51:57 -0400
Message-ID: <5047047D.7000406@redhat.com>
Date: Wed, 05 Sep 2012 10:51:25 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1346771610-52423-1-git-send-email-cornelia.huck@de.ibm.com>
In-Reply-To: <1346771610-52423-1-git-send-email-cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v2 0/7] s390: virtual css host support.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-s390 <linux-s390@vger.kernel.org>, Anthony Liguori <aliguori@us.ibm.com>, Rusty Russell <rusty@rustcorp.com.au>, KVM <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>, Sebastian Ott <sebott@linux.vnet.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>

On 09/04/2012 06:13 PM, Cornelia Huck wrote:
> Hi,
> 
> here's the second revision of the virtual channel subsystem support for
> s390.
> 
> I changed the representation of the channel subsystem, introducing channel
> subsystem images, which brings it closer to the actual implementation. A
> new ioctl for adding a new channel subsystem image has also been introduced.

Looks good to me, though of course I could only do a shallow review.

I'd like to see acks from an s390 maintainer on the non-kvm patches, and
will apply after the other comments are addressed.


-- 
error compiling committee.c: too many arguments to function