qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Henning Schild <henning@hennsch.de>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option
Date: Wed, 05 Sep 2012 15:11:13 +0200	[thread overview]
Message-ID: <50474F71.6000001@redhat.com> (raw)
In-Reply-To: <9fb1f27468f3dcfd01078182e18288ae-EhVcX11BQgteRwEVBgsBVggwfgFLV15YQUBGAEFeXC9ZXF0WXV9xH1BLXzBeQkEEV15QR1Fc-webmailer2@server04.webmailer.hosteurope.de>

Am 05.09.2012 14:56, schrieb Henning Schild:
>  Find a hopefully proper patch attached. Take it or leave it.
> 
>  Signed-off-by: Henning Schild <henning@hennsch.de>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Aurelien, I think in the past you committed some changes in this area.
Does this look good to you and can you get it committed?

Kevin

>  ---
>   hw/elf_ops.h |   11 +++++++++++
>   1 files changed, 11 insertions(+), 0 deletions(-)
> 
>  diff --git a/hw/elf_ops.h b/hw/elf_ops.h
>  index fa65ce2..731a983 100644
>  --- a/hw/elf_ops.h
>  +++ b/hw/elf_ops.h
>  @@ -269,6 +269,17 @@ static int glue(load_elf, SZ)(const char *name, 
>  int fd,
>                   addr = ph->p_paddr;
>               }
>  
>  +            /* the entry pointer in the ELF header is a virtual
>  +             * address, if the text segments paddr and vaddr differ
>  +             * we need to adjust the entry */
>  +            if (pentry && !translate_fn &&
>  +                    ph->p_vaddr != ph->p_paddr &&
>  +                    ehdr.e_entry >= ph->p_vaddr &&
>  +                    ehdr.e_entry < ph->p_vaddr + ph->p_filesz &&
>  +                    ph->p_flags & PF_X) {
>  +                *pentry = ehdr.e_entry - ph->p_vaddr + ph->p_paddr;
>  +            }
>  +
>               snprintf(label, sizeof(label), "phdr #%d: %s", i, name);
>               rom_add_blob_fixed(label, data, mem_size, addr);
>  
> 

  reply	other threads:[~2012-09-05 13:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05  9:05 [Qemu-devel] [PATCH] fix entry pointer for ELF kernels loaded with -kernel option Henning Schild
2012-09-05  9:36 ` Dunrong Huang
2012-09-05 10:53 ` Kevin Wolf
2012-09-05 12:56   ` Henning Schild
2012-09-05 13:11     ` Kevin Wolf [this message]
2012-09-07 14:10       ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50474F71.6000001@redhat.com \
    --to=kwolf@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=henning@hennsch.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).