From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Llu-0003ih-Id for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:00:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9Llt-0005Yr-5p for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:00:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9Lls-0005YH-Tz for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:00:21 -0400 Message-ID: <5047AF52.1060607@redhat.com> Date: Wed, 05 Sep 2012 14:00:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1346872724-9156-1-git-send-email-aliguori@us.ibm.com> <1346872724-9156-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7E3527163A81A00A7E7A7A83" Subject: Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7E3527163A81A00A7E7A7A83 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/05/2012 01:53 PM, Blue Swirl wrote: > On Wed, Sep 5, 2012 at 7:18 PM, Anthony Liguori w= rote: >> This is minimalistic and just contains the basic widget infrastructure= =2E The GUI >> consists of a menu and a GtkNotebook. To start with, the notebook has= its tabs >> hidden which provides a UI that looks very similar to SDL with the exc= eption of >> the menu bar. >> >> +#ifdef DEBUG_GTK >> +#define dprintf(fmt, ...) printf(fmt, ## __VA_ARGS__) >=20 > dprintf is actually defined by stdio.h. Either rename or #undef first. Worse than that, dprintf() is mandated by POSIX 2008, and you are using a reserved name with different meaning, which can give undefined behavior. Your best bet is to use a name other than dprintf. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig7E3527163A81A00A7E7A7A83 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQR69SAAoJEKeha0olJ0NqpR8H/iYG/1Y1ft/fDTbMq5dM2S+l p5lFgNinNcoyEhcGWs2YinwU7NCeawHpss2RoPqAMFVktCZjx8JSBXQymkA12KHc NNnGIMifgKru05BBBHeB7mivpj2a/zZIOAege/hQ8VGLhlDxgrqJiPT9Ts0B7zRw aQNTva8xnXnQ+TjJR6Rg/BCCfJK7jAvDiSloJdmOPOZT4ewtqF0tSFVx7assvXpL uk6a/y9WSe50xLlR/r3SJQ9Byl7vUR58VeATDmCmiMPKKaDKNEF1z0XEsXU3J+Up 2fhWAvwsv+Hq991OWtiaESSBYtqt58TRPASyflOYWAxutDEF8TCBqy4Je25jBJs= =Tx3l -----END PGP SIGNATURE----- --------------enig7E3527163A81A00A7E7A7A83--