From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9MUM-0000be-Bv for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:46:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9MUL-0003oV-4l for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:46:18 -0400 Received: from mout.web.de ([212.227.15.3]:53703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9MUK-0003oP-RA for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:46:17 -0400 Message-ID: <5047B9F3.2000507@web.de> Date: Wed, 05 Sep 2012 22:45:39 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1346872724-9156-1-git-send-email-aliguori@us.ibm.com> <1346872724-9156-3-git-send-email-aliguori@us.ibm.com> <5047B046.6040503@weilnetz.de> In-Reply-To: <5047B046.6040503@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA43235EF829B10C6401D7240" Subject: Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA43235EF829B10C6401D7240 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-09-05 22:04, Stefan Weil wrote: > Am 05.09.2012 21:18, schrieb Anthony Liguori: >> This is minimalistic and just contains the basic widget >> infrastructure. The GUI >> consists of a menu and a GtkNotebook. To start with, the notebook has= >> its tabs >> hidden which provides a UI that looks very similar to SDL with the >> exception of >> the menu bar. >> >> The menu bar allows a user to toggle the visibility of the tabs.=20 >> Cairo is used >> for rendering. >> >> I used gtk-vnc as a reference. gtk-vnc solves the same basic problems= >> as QEMU >> since it was originally written as a remote display for QEMU. So for >> the most >> part, the approach to rendering and keyboard handling should be pretty= >> solid for >> GTK. >> >> Signed-off-by: Anthony Liguori >> --- >> v1 -> v2 >> - add gtk-vnc license >> - fix key propagation >> --- >> Makefile | 2 + >> configure | 25 +++- >> console.h | 4 + >> sysemu.h | 1 + >> ui/Makefile.objs | 1 + >> ui/gtk.c | 572 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 6 files changed, 604 insertions(+), 1 deletions(-) >> create mode 100644 ui/gtk.c >> >=20 > Hi Anthony, >=20 > I tested the previous version of your series and noticed that the > menu accelerators (especially for file/quit) which are still part of > this new patch are a bad idea. >=20 > Just run a system emulation, start some GUI program in the emulation > and press Ctrl-Q: you won't terminate the GUI program, but terminate > QEMU! Yep, standard accelerators must go, definitely while the input is grabbed= =2E Jan --------------enigA43235EF829B10C6401D7240 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBHufMACgkQitSsb3rl5xRHBQCfSh87n1tte8dH2KcHMfS1z8qs 3ckAn0BR+ks7A7t8H+rgHdLs81TgXj9r =6rp8 -----END PGP SIGNATURE----- --------------enigA43235EF829B10C6401D7240--