From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9MdF-0003ZX-62 for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9MdD-0006hi-4B for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:55:29 -0400 Received: from mout.web.de ([212.227.15.4]:65144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9MdC-0006he-Pq for qemu-devel@nongnu.org; Wed, 05 Sep 2012 16:55:27 -0400 Message-ID: <5047BC20.8000403@web.de> Date: Wed, 05 Sep 2012 22:54:56 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1346872724-9156-1-git-send-email-aliguori@us.ibm.com> <1346872724-9156-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1346872724-9156-3-git-send-email-aliguori@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4E91107D5381F6217BE3193A" Subject: Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4E91107D5381F6217BE3193A Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-09-05 21:18, Anthony Liguori wrote: > This is minimalistic and just contains the basic widget infrastructure.= The GUI > consists of a menu and a GtkNotebook. To start with, the notebook has = its tabs > hidden which provides a UI that looks very similar to SDL with the exce= ption of > the menu bar. >=20 > The menu bar allows a user to toggle the visibility of the tabs. Cairo= is used > for rendering. >=20 > I used gtk-vnc as a reference. gtk-vnc solves the same basic problems = as QEMU > since it was originally written as a remote display for QEMU. So for t= he most > part, the approach to rendering and keyboard handling should be pretty = solid for > GTK. >=20 > Signed-off-by: Anthony Liguori > --- > v1 -> v2 > - add gtk-vnc license > - fix key propagation =2E.. > +static void gd_create_menus(GtkDisplayState *s) > +{ > + GtkStockItem item; > + GtkAccelGroup *accel_group; > + GSList *group =3D NULL; > + GtkWidget *separator; > + > + accel_group =3D gtk_accel_group_new(); > + s->file_menu =3D gtk_menu_new(); > + gtk_menu_set_accel_group(GTK_MENU(s->file_menu), accel_group); > + s->file_menu_item =3D gtk_menu_item_new_with_mnemonic("_File"); > + > + s->quit_item =3D gtk_image_menu_item_new_from_stock(GTK_STOCK_QUIT= , NULL); > + gtk_stock_lookup(GTK_STOCK_QUIT, &item); > + gtk_menu_item_set_accel_path(GTK_MENU_ITEM(s->quit_item), > + "/File/Quit"); > + gtk_accel_map_add_entry("/File/Quit", item.keyval, item.modi= fier); > + > + s->view_menu =3D gtk_menu_new(); > + gtk_menu_set_accel_group(GTK_MENU(s->view_menu), accel_group); > + s->view_menu_item =3D gtk_menu_item_new_with_mnemonic("_View"); > + > + separator =3D gtk_separator_menu_item_new(); > + gtk_menu_append(GTK_MENU(s->view_menu), separator); > + > + s->vga_item =3D gtk_radio_menu_item_new_with_mnemonic(group, "_VGA= "); Minor nit, but "VGA" is the wrong name for QEMU in general. Maybe "Displa= y"? Jan --------------enig4E91107D5381F6217BE3193A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBHvCAACgkQitSsb3rl5xQoTgCfR2UTFWty+lhUIEdgBuPpGTta 3vAAn2p5E3YwCYjhJtudTRVrQTD/CptK =FdpW -----END PGP SIGNATURE----- --------------enig4E91107D5381F6217BE3193A--