From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9OLR-0001ls-TU for qemu-devel@nongnu.org; Wed, 05 Sep 2012 18:45:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9OLQ-00026L-E4 for qemu-devel@nongnu.org; Wed, 05 Sep 2012 18:45:13 -0400 Received: from mout.web.de ([212.227.17.12]:59540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9OLQ-00024q-3O for qemu-devel@nongnu.org; Wed, 05 Sep 2012 18:45:12 -0400 Message-ID: <5047D5EB.7060602@web.de> Date: Thu, 06 Sep 2012 00:44:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1342100216-1832-1-git-send-email-peter.maydell@linaro.org> <1342100216-1832-7-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1342100216-1832-7-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1748E656C560CE331F9BA5CD" Subject: Re: [Qemu-devel] [PATCH 06/15] ARM: Make target_phys_addr_t 64 bits and physaddrs 40 bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , qemu-devel@nongnu.org, Anthony Liguori , Paul Brook This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig1748E656C560CE331F9BA5CD Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-07-12 15:36, Peter Maydell wrote: > Make target_phys_addr_t 64 bits for ARM targets, and set > TARGET_PHYS_ADDR_SPACE_BITS to 40. This should have no effect for ARM > boards where physical addresses really are 32 bits (except perhaps a > slight performance hit on 32 bit hosts for system emulation) but allows= > us to implement the Large Physical Address Extensions for Cortex-A15, > which mean 40 bit physical addresses. >=20 > Signed-off-by: Peter Maydell > --- > configure | 2 +- > target-arm/cpu.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/configure b/configure > index 500fe24..32a8290 100755 > --- a/configure > +++ b/configure > @@ -3571,7 +3571,7 @@ case "$target_arch2" in > bflt=3D"yes" > target_nptl=3D"yes" > gdb_xml_files=3D"arm-core.xml arm-vfp.xml arm-vfp3.xml arm-neon.xm= l" > - target_phys_bits=3D32 > + target_phys_bits=3D64 > target_llong_alignment=3D4 > target_libs_softmmu=3D"$fdt_libs" > ;; > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > index 33afa18..aadfca0 100644 > --- a/target-arm/cpu.h > +++ b/target-arm/cpu.h > @@ -619,7 +619,7 @@ static inline bool cp_access_ok(CPUARMState *env, > #define TARGET_PAGE_BITS 10 > #endif > =20 > -#define TARGET_PHYS_ADDR_SPACE_BITS 32 > +#define TARGET_PHYS_ADDR_SPACE_BITS 40 > #define TARGET_VIRT_ADDR_SPACE_BITS 32 > =20 > static inline CPUARMState *cpu_init(const char *cpu_model) >=20 After this change, the Musicpal board no longer boots. The symptoms are just like stealing its flash completely: u-boot fails to find the kernel image in the flash partition. That makes me think we have some address size related issues in pflash_cfi02. Any other spontaneous ideas where to dig? Jan --------------enig1748E656C560CE331F9BA5CD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBH1e8ACgkQitSsb3rl5xRIJgCggsmNB3Vm2Dhksm3phdxZ/79V nMoAn1igKTe36rOhLE00XHkC1Tr0KjR9 =yj3k -----END PGP SIGNATURE----- --------------enig1748E656C560CE331F9BA5CD--