From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9W1s-0000np-AM for qemu-devel@nongnu.org; Thu, 06 Sep 2012 02:57:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9W1r-00020v-Cc for qemu-devel@nongnu.org; Thu, 06 Sep 2012 02:57:32 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:47808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9W1r-00020r-6Y for qemu-devel@nongnu.org; Thu, 06 Sep 2012 02:57:31 -0400 Received: by dadn15 with SMTP id n15so906914dad.4 for ; Wed, 05 Sep 2012 23:57:30 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5048494D.2070108@redhat.com> Date: Thu, 06 Sep 2012 08:57:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1346879185-19299-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1346879185-19299-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5 v3] convert system_powerdown command to notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com Il 05/09/2012 23:06, Igor Mammedov ha scritto: > global variable qemu_system_powerdown in sysemu.h is the only dep for qemu_irq > and qemu_rise_irq is not a generic way to signal guest that it should shutdown. > > replace it by notifiers and allow each implementation to have it's own way > to notify guest. > > git repo for testing: > https://github.com/imammedo/qemu/tree/shutdown_notifier.v3 > > compile tested: > target-list=x86_64-linux-user,x86_64-softmmu,sparc-softmmu,arm-softmmu > runtime tested: > x86_64-softmmu + win7 guest > > v3-v2: > - fixed bisectably issues of series > - make series independed of cpu_as_device series > > Igor Mammedov (5): > Introduce powerdown_notifiers > acpi: use notifier for signaling guest system_powerdown command > target-arm: use notifier for signaling guest system_powerdown command > target-sparc: use notifier for signaling guest system_powerdown > command > Cleanup unused global var qemu_system_powerdown > > hw/acpi_piix4.c | 8 +++++--- > hw/nseries.c | 14 +++++++++++++- > hw/sun4m.c | 14 +++++++++++++- > sysemu.h | 2 +- > vl.c | 18 ++++++++++++++---- > 5 files changed, 46 insertions(+), 10 deletions(-) > Series Reviewed-by: Paolo Bonzini Paolo