From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9XXz-0006TH-8V for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:34:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9XXt-0007qe-Fi for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:34:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9XXt-0007qa-7X for qemu-devel@nongnu.org; Thu, 06 Sep 2012 04:34:41 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q868YeLl009204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Sep 2012 04:34:40 -0400 Message-ID: <5048601F.5060409@redhat.com> Date: Thu, 06 Sep 2012 10:34:39 +0200 From: Pavel Hrdina MIME-Version: 1.0 References: <1a792397f896fe2c5106eb55e58d0e3c8a3032c3.1345016001.git.phrdina@redhat.com> <20120830091143.0ceb60c4@doriath.home> In-Reply-To: <20120830091143.0ceb60c4@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/18] qerror: introduce QERR_GENERIC_ERROR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org On 08/30/2012 02:11 PM, Luiz Capitulino wrote: > On Wed, 15 Aug 2012 09:41:42 +0200 > Pavel Hrdina wrote: > >> Signed-off-by: Pavel Hrdina >> --- >> qerror.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/qerror.h b/qerror.h >> index d0a76a4..7e0bae7 100644 >> --- a/qerror.h >> +++ b/qerror.h >> @@ -120,6 +120,9 @@ void assert_no_error(Error *err); >> #define QERR_FEATURE_DISABLED \ >> ERROR_CLASS_GENERIC_ERROR, "The feature '%s' is not enabled" >> >> +#define QERR_GENERIC_ERROR \ >> + ERROR_CLASS_GENERIC_ERROR, "An (Errno %d) error has occurred" >> + > You should use error_setg() instead: I'll fix it for whole patch-series. > > http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg04980.html > > There usage examples in the series introducing it. It would be better > to wait for it to be merged before you use it though, as it's always > possible for people to ask for changes. > >> #define QERR_INVALID_BLOCK_FORMAT \ >> ERROR_CLASS_GENERIC_ERROR, "Invalid block format '%s'" >>