From: Gerd Hoffmann <kraxel@redhat.com>
To: Alejandro Martinez <alex@securiforest.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers
Date: Thu, 06 Sep 2012 12:15:52 +0200 [thread overview]
Message-ID: <504877D8.3030704@redhat.com> (raw)
In-Reply-To: <CAFwFPkz3ko8EBwajgFstX-HToWXqL3EXyoZ2gMqWweguMEZVDw@mail.gmail.com>
Hi,
> usb-next will fail to compile using -Werror with:
> hcd-xhci.c: In function ‘xhci_fire_ctl_transfer’:
> hcd-xhci.c:1508:14: error: variable ‘wLength’ set but not used
> [-Werror=unused-but-set-variable]
Fixed.
Which gcc is this? Must be pretty cutting edge, even on Fedora 17 (gcc
4.7.0) I don't see that one ...
> It will also crash at runtime at
> host-linux.c:usb_handle_control_packet(), since a NULL value is passed
> from xhci_address_slot() for the USBPacket *p argument, and an assert
> is testing for p->result == 0.
Fixed & pushed to usb-next.
thanks,
Gerd
next prev parent reply other threads:[~2012-09-06 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 12:49 [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers Alejandro Martinez Ruiz
2012-09-04 13:30 ` Gerd Hoffmann
2012-09-06 9:20 ` Alejandro Martinez
2012-09-06 10:15 ` Gerd Hoffmann [this message]
2012-09-06 10:42 ` Alejandro Martinez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504877D8.3030704@redhat.com \
--to=kraxel@redhat.com \
--cc=alex@securiforest.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).