From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T9Z7w-0005HA-Pp
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:16:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T9Z7r-0003IG-32
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:16:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T9Z7q-0003I3-N6
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:15:55 -0400
Message-ID: <504877D8.3030704@redhat.com>
Date: Thu, 06 Sep 2012 12:15:52 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1346330948-12833-1-git-send-email-alex@securiforest.com>
	<50460275.2020506@redhat.com>
	<CAFwFPkz3ko8EBwajgFstX-HToWXqL3EXyoZ2gMqWweguMEZVDw@mail.gmail.com>
In-Reply-To: <CAFwFPkz3ko8EBwajgFstX-HToWXqL3EXyoZ2gMqWweguMEZVDw@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to
 capability registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alejandro Martinez <alex@securiforest.com>
Cc: qemu-devel@nongnu.org

  Hi,

> usb-next will fail to compile using -Werror with:
> hcd-xhci.c: In function =91xhci_fire_ctl_transfer=92:
> hcd-xhci.c:1508:14: error: variable =91wLength=92 set but not used
> [-Werror=3Dunused-but-set-variable]

Fixed.

Which gcc is this?  Must be pretty cutting edge, even on Fedora 17 (gcc
4.7.0) I don't see that one ...

> It will also crash at runtime at
> host-linux.c:usb_handle_control_packet(), since a NULL value is passed
> from xhci_address_slot() for the USBPacket *p argument, and an assert
> is testing for p->result =3D=3D 0.

Fixed & pushed to usb-next.

thanks,
  Gerd