From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9ZJj-0001cA-Pu for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:28:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9ZJi-0007Bi-GX for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:28:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54283 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9ZJi-0007Be-AD for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:28:10 -0400 Message-ID: <50487AB5.8060407@suse.de> Date: Thu, 06 Sep 2012 12:28:05 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1346354435-21685-1-git-send-email-Don@CloudSwitch.com> In-Reply-To: <1346354435-21685-1-git-send-email-Don@CloudSwitch.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Don Slutz Cc: Eduardo Habkost , kvm@vger.kernel.org, Don Slutz , Marcelo Tosatti , qemu-devel@nongnu.org, Avi Kivity , Igor Mammedov Am 30.08.2012 21:20, schrieb Don Slutz: > This is primarily done so that the guest will think it is running > under vmware when hypervisor=3Dvmware is specified as a property of a > cpu. >=20 > Also allow this to work in accel=3Dtcg mode. >=20 > The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and > hyper_extra_b can be used to further adjust what the guest sees. >=20 > Signed-off-by: Don Slutz > --- > target-i386/cpu.c | 178 +++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > target-i386/cpu.h | 9 +++ > target-i386/kvm.c | 33 ++++++++-- > 3 files changed, 214 insertions(+), 6 deletions(-) Please don't add new CPU command line options without matching QOM properties. There are patch series in the works that convert the CPU definitions to QOM subclasses, the parameters then need to be set on the X86CPU object instance. Note that the convention for QOM properties is descriptive-name-with-dashes rather than shortened_abbrev_with_underscore= . Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg