From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable
Date: Thu, 06 Sep 2012 12:47:53 +0200 [thread overview]
Message-ID: <50487F59.701@redhat.com> (raw)
In-Reply-To: <CAFEAcA_tAA1wqPBeywCMgxgNkAcrYkd8GewrSNX=vEb_mbm3cw@mail.gmail.com>
On 09/06/12 09:48, Peter Maydell wrote:
> On 6 September 2012 08:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> @@ -789,6 +790,13 @@ static int serial_isa_initfn(ISADevice *dev)
>> isa->isairq = isa_serial_irq[isa->index];
>> index++;
>>
>> + if (isa->iobase == 0x3f8) {
>> + s->reason = QEMU_WAKEUP_REASON_GPE_a;
>> + s->wakeup = 1;
>> + } else {
>> + s->reason = QEMU_WAKEUP_REASON_OTHER;
>> + }
>> +
>
> It seems a bit odd that this is done in the ISA serial model
> itself and not by the next level up wiring up some output
> of the ISA serial device to some appropriate input...
Suggestions how to do that are welcome. Preferably some which don't
break on 'qemu -nodefault -device isa-serial,chardev=foo'.
cheers,
Gerd
next prev parent reply other threads:[~2012-09-06 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 7:42 [Qemu-devel] [PULL 0/4] wakeup: make wakeup events guest-configurable Gerd Hoffmann
2012-09-06 7:42 ` [Qemu-devel] [PATCH 1/4] wakeup: add acpi gpe wakeup reasons Gerd Hoffmann
2012-09-06 7:42 ` [Qemu-devel] [PATCH 2/4] wakeup: make ps/2 configurable Gerd Hoffmann
2012-09-06 7:42 ` [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable Gerd Hoffmann
2012-09-06 7:48 ` Peter Maydell
2012-09-06 10:47 ` Gerd Hoffmann [this message]
2012-09-08 7:15 ` Blue Swirl
2012-09-08 10:34 ` Paolo Bonzini
2012-09-10 16:02 ` Anthony Liguori
2012-09-10 16:07 ` Paolo Bonzini
2012-09-10 16:16 ` Peter Maydell
2012-09-10 17:19 ` Anthony Liguori
2012-09-10 5:47 ` Gerd Hoffmann
2012-09-06 7:42 ` [Qemu-devel] [PATCH 4/4] wakeup: uhci support Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50487F59.701@redhat.com \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).