From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36634)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T9Zct-00082Z-5d
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:48:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T9Zcs-0005Hq-9M
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:47:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46461)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1T9Zcs-0005Hl-0v
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 06:47:58 -0400
Message-ID: <50487F59.701@redhat.com>
Date: Thu, 06 Sep 2012 12:47:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1346917367-24691-1-git-send-email-kraxel@redhat.com>
	<1346917367-24691-4-git-send-email-kraxel@redhat.com>
	<CAFEAcA_tAA1wqPBeywCMgxgNkAcrYkd8GewrSNX=vEb_mbm3cw@mail.gmail.com>
In-Reply-To: <CAFEAcA_tAA1wqPBeywCMgxgNkAcrYkd8GewrSNX=vEb_mbm3cw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

On 09/06/12 09:48, Peter Maydell wrote:
> On 6 September 2012 08:42, Gerd Hoffmann <kraxel@redhat.com> wrote:
>> @@ -789,6 +790,13 @@ static int serial_isa_initfn(ISADevice *dev)
>>          isa->isairq = isa_serial_irq[isa->index];
>>      index++;
>>
>> +    if (isa->iobase == 0x3f8) {
>> +        s->reason = QEMU_WAKEUP_REASON_GPE_a;
>> +        s->wakeup = 1;
>> +    } else {
>> +        s->reason = QEMU_WAKEUP_REASON_OTHER;
>> +    }
>> +
> 
> It seems a bit odd that this is done in the ISA serial model
> itself and not by the next level up wiring up some output
> of the ISA serial device to some appropriate input...

Suggestions how to do that are welcome.  Preferably some which don't
break on 'qemu -nodefault -device isa-serial,chardev=foo'.

cheers,
  Gerd