From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9dUs-0000oy-7H for qemu-devel@nongnu.org; Thu, 06 Sep 2012 10:56:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9dUo-0005I7-TP for qemu-devel@nongnu.org; Thu, 06 Sep 2012 10:55:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9dUo-0005Hn-Jg for qemu-devel@nongnu.org; Thu, 06 Sep 2012 10:55:54 -0400 Message-ID: <5048B976.7070508@redhat.com> Date: Thu, 06 Sep 2012 08:55:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1346939680-13238-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1346939680-13238-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigB2A69EDF9734113B6954982B" Subject: Re: [Qemu-devel] [PATCH] qemu-options.hx: Change from recommending '?' to 'help' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , qemu-devel@nongnu.org, patches@linaro.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB2A69EDF9734113B6954982B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/06/2012 07:54 AM, Peter Maydell wrote: > Update the -help output and documentation so that it recommends > 'help' rather than '?' for the various "list valid values for this > option" cases. '?' is deprecated (as it can fail confusingly if > not quoted), so it's better to steer users towards 'help'. ('?' > still works, for backwards compatibility.) >=20 > This is the -help option part of the change otherwise done in > commit c8057f9, since we are now past release 1.2 and free to > change our help text without worrying about breaking libvirt. Agreed on that point. > DEF("machine", HAS_ARG, QEMU_OPTION_machine, \ > "-machine [type=3D]name[,prop[=3Dvalue][,...]]\n" > - " selects emulated machine (-machine ? for list)\n"= > + " selects emulated machine (-machine help for list)= \n" Would it help to add some quoting? " selects emulated machine ('-machine help' for list)\n" > @@ -64,11 +60,11 @@ HXCOMM Deprecated by -machine > DEF("M", HAS_ARG, QEMU_OPTION_M, "", QEMU_ARCH_ALL) > =20 > DEF("cpu", HAS_ARG, QEMU_OPTION_cpu, > - "-cpu cpu select CPU (-cpu ? for list)\n", QEMU_ARCH_ALL) > + "-cpu cpu select CPU (-cpu help for list)\n", QEMU_ARCH_ALL= ) Here as well. > STEXI > @item -cpu @var{model} > @findex -cpu > -Select CPU model (-cpu ? for list and additional feature selection) > +Select CPU model (-cpu help for list and additional feature selection)= @code{-cpu help} here, to match the @code{-machine help} above. > ETEXI > =20 > DEF("smp", HAS_ARG, QEMU_OPTION_smp, > @@ -452,12 +448,12 @@ ETEXI > DEF("soundhw", HAS_ARG, QEMU_OPTION_soundhw, > "-soundhw c1,... enable audio support\n" > " and only specified sound cards (comma separated l= ist)\n" > - " use -soundhw ? to get the list of supported cards= \n" > + " use -soundhw help to get the list of supported ca= rds\n" Similar comments apply to the rest of the patch... --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigB2A69EDF9734113B6954982B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQSLl2AAoJEKeha0olJ0NqcmgH+wdfrxntX9Sh3mTLLaks55Y5 rhHSlfuPgFtfcFuQD+H8H68bl50I3LeNqCfe6L3/P96GSmm9jPUtZgWYwCdk1b9E iGO4hvaG4Sl6C3sKZb0HfwqV1s58mCf5keM9AoeyDIkdDVR8ao2Gird9z4G8DxFB /tYbSIbzmkEUDcjmyibJPxUUEvKfrc47NpLZQJbjrdwf43zX2sTOlrczlbkQMhMJ ZIKKqFiUSMN1xSO/LKDt1oSLU82sJ4eiL1vCv8xKkY+Whs8n75ST2xyXwIIFljUA vvQ2pgEIKV6Ie2KQIn2tRb3s6dInWwXkSdvEkwNABzyXoubTcfgJZ/9+OZEzBps= =KyDu -----END PGP SIGNATURE----- --------------enigB2A69EDF9734113B6954982B--