From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Don Slutz <Don@cloudswitch.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] CHECKPATCH
Date: Thu, 06 Sep 2012 18:32:26 +0300 [thread overview]
Message-ID: <5048C20A.4080107@redhat.com> (raw)
In-Reply-To: <CAAu8pHu=1HmiTJOBkJnNdezgkfs5fa8VKsPdGoWwMmdjjJ01Jg@mail.gmail.com>
On 09/02/2012 01:51 PM, Blue Swirl wrote:
> I've used the following snippet to check what happens with the last 100 commits:
> for i in '' 1 2 3 4 5 6 7 8 9; do for j in 0 1 2 3 4 5 6 7 8 9; do
> echo $i$j; git show HEAD~$i$j >/tmp/a; clear;head -20 /tmp/a;
> ./scripts/checkpatch.pl --root=. /tmp/a; read foo; done; done
>
> Sadly, it also shows how much stuff gets committed without checking,
> and on the other hand, the amount of false alarms.
Maintainers should add a checkpatch invocation as a git hook (advisory
only), this could reduce the amount of violations getting into the tree.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-09-06 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 15:57 [Qemu-devel] [PATCH] CHECKPATCH Don Slutz
2012-09-01 15:57 ` [Qemu-devel] [PATCH] CHECKPATCH: Add warning for single else statement Don Slutz
2012-09-02 10:52 ` Blue Swirl
2012-09-02 10:51 ` [Qemu-devel] [PATCH] CHECKPATCH Blue Swirl
2012-09-06 15:32 ` Avi Kivity [this message]
2012-09-08 7:33 ` Blue Swirl
2012-09-02 23:22 ` [Qemu-devel] [PATCH v2 0/4] CHECKPATCH: Add warning for single else statement Don Slutz
2012-09-05 19:46 ` Blue Swirl
2012-09-06 10:32 ` Andreas Färber
2012-09-08 7:08 ` Blue Swirl
2012-09-02 23:22 ` [Qemu-devel] [PATCH v2 1/4] CHECKPATCH: Add --debug adv_dcs Don Slutz
2012-09-02 23:22 ` [Qemu-devel] [PATCH v2 2/4] CHECKPATCH: Add --debug adv_checking Don Slutz
2012-09-02 23:22 ` [Qemu-devel] [PATCH v2 3/4] CHECKPATCH: Add --debug adv_apw Don Slutz
2012-09-02 23:22 ` [Qemu-devel] [PATCH v2 4/4] CHECKPATCH: Add warning for single else statement Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5048C20A.4080107@redhat.com \
--to=avi@redhat.com \
--cc=Don@cloudswitch.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).