From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9e4L-0008Ik-Gk for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:32:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9e4F-0001Lt-Pq for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:32:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9e4F-0001Ln-Ho for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:32:31 -0400 Message-ID: <5048C20A.4080107@redhat.com> Date: Thu, 06 Sep 2012 18:32:26 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1346515062-13067-1-git-send-email-Don@CloudSwitch.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] CHECKPATCH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Don Slutz , qemu-devel@nongnu.org On 09/02/2012 01:51 PM, Blue Swirl wrote: > I've used the following snippet to check what happens with the last 100 commits: > for i in '' 1 2 3 4 5 6 7 8 9; do for j in 0 1 2 3 4 5 6 7 8 9; do > echo $i$j; git show HEAD~$i$j >/tmp/a; clear;head -20 /tmp/a; > ./scripts/checkpatch.pl --root=. /tmp/a; read foo; done; done > > Sadly, it also shows how much stuff gets committed without checking, > and on the other hand, the amount of false alarms. Maintainers should add a checkpatch invocation as a git hook (advisory only), this could reduce the amount of violations getting into the tree. -- error compiling committee.c: too many arguments to function