From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1T9eGV-0006fb-Fy
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:45:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1T9eGP-00051f-BT
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:45:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7816)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1T9eGO-0004zg-T0
	for qemu-devel@nongnu.org; Thu, 06 Sep 2012 11:45:05 -0400
Message-ID: <5048C4F7.4030901@redhat.com>
Date: Thu, 06 Sep 2012 17:44:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20120809130010.GA7960@in.ibm.com>
	<20120809130216.GC7960@in.ibm.com> <5028F815.40309@redhat.com>
	<20120814043801.GB24944@in.ibm.com> <502A0C66.3060107@redhat.com>
	<20120814093430.GE24944@in.ibm.com>
	<502A2140.9050703@redhat.com> <50485EF0.70505@redhat.com>
	<20120906154004.GB20421@in.ibm.com>
In-Reply-To: <20120906154004.GB20421@in.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU
 block backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: bharata@linux.vnet.ibm.com
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Vijay Bellur <vbellur@redhat.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>

Il 06/09/2012 17:40, Bharata B Rao ha scritto:
> > > > I don't think we can fit 'unix' within the standard URI scheme (RFC 3986)
> > > > easily, but I am planning to specify the 'unix' transport as below:
> > > > 
> > > > gluster://[/path/to/unix/domain/socket]/volname/image?transport=unix
> > > > 
> > > > i,e., I am asking the user to put the unix domain socket path within
> > > > square brackets when transport type is unix.
> > > 
> > > Never saw something like this before, but it does seem reasonable to me.
> > > Excludes ] from the valid characters in the file name of the socket, but
> > > that shouldn't be a problem in practice.
> > 
> > Bikeshedding, but I prefer
> > 
> >   gluster:///path/to/unix/domain/socket:/volname/image?transport=unix
> 
> Unless you or others strongly feel about this, I would like to go with
> [ ] based spec, which I feel is less prone to errors like missing a colon
> by mistake :)

Your proposed spec has the disadvantage of not being a proper URL.

What about this instead:

gluster:///path/to/unix/domain/socket!/volname/image?transport=unix

since (http://www.w3.org/Addressing/URL/uri-spec.html) "The asterisk
("*", ASCII 2A hex) and exclamation mark ("!" , ASCII 21 hex) are
reserved for use as having special signifiance within specific schemes".

Paolo