From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9vRv-00071X-0m for qemu-devel@nongnu.org; Fri, 07 Sep 2012 06:06:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9vRk-0004n9-R2 for qemu-devel@nongnu.org; Fri, 07 Sep 2012 06:06:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9vRk-0004mv-LE for qemu-devel@nongnu.org; Fri, 07 Sep 2012 06:05:56 -0400 Message-ID: <5049C6FB.9080900@redhat.com> Date: Fri, 07 Sep 2012 12:05:47 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20120809130216.GC7960@in.ibm.com> <5028F815.40309@redhat.com> <20120814043801.GB24944@in.ibm.com> <502A0C66.3060107@redhat.com> <20120814093430.GE24944@in.ibm.com> <502A2140.9050703@redhat.com> <50485EF0.70505@redhat.com> <20120906154004.GB20421@in.ibm.com> <20120906154717.GI3077@redhat.com> <5049C5D2.2030408@redhat.com> <20120907100340.GC23416@redhat.com> In-Reply-To: <20120907100340.GC23416@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Kevin Wolf , Anthony Liguori , Anand Avati , Stefan Hajnoczi , Vijay Bellur , Amar Tumballi , qemu-devel@nongnu.org, Blue Swirl , Avi Kivity , Bharata B Rao Il 07/09/2012 12:03, Daniel P. Berrange ha scritto: >> > I think doing it the other way round would be more logical: >> > >> > gluster+unix:///path/to/unix/sock?image=volname/image >> > >> > This way you have the socket first, which you also must open first. >> > Having it as a parameter without which you can't make sense of the path >> > feels a bit less than ideal. > The issue here is that the volume/path/to/image part is something that is > required for all gluster transports. The /path/to/unix/sock is something > that is only required for the unix transport. To have consistent URI > scheme across all transports, you really want the volume/path/to/image > bit to use the URI path component. I was writing the same---plus, perhaps there is a default for the Unix socket path, so that in the common case you could avoid the parameters altogether? Paolo