From: Paolo Bonzini <pbonzini@redhat.com>
To: jcody@redhat.com
Cc: kwolf@redhat.com, supriyak@linux.vnet.ibm.com, eblake@redhat.com,
qemu-devel@nongnu.org, stefanha@gmail.com
Subject: Re: [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb
Date: Fri, 07 Sep 2012 19:09:32 +0200 [thread overview]
Message-ID: <504A2A4C.2040301@redhat.com> (raw)
In-Reply-To: <504A292E.8020400@redhat.com>
Il 07/09/2012 19:04, Jeff Cody ha scritto:
> On 09/07/2012 12:27 PM, Paolo Bonzini wrote:
>> Il 30/08/2012 20:47, Jeff Cody ha scritto:
>>> @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = {
>>> [IF_SCSI] = 7,
>>> };
>>>
>>> +static void block_job_cb(void *opaque, int ret);
>>> +
>>> /*
>>> * We automatically delete the drive when a device using it gets
>>> * unplugged. Questionable feature, but we can't just drop it.
>>
>> Can you avoid the forward declaration?
>>
>> Paolo
>>
>
> Yes, sure - honestly, I added this patch in, but I assumed that the
> similar patch of yours to support mirroring would go in first, making
> this patch moot.
I now took this patch of yours in my tree (minus the forward
declaration), so...
Paolo
next prev parent reply other threads:[~2012-09-07 17:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 18:47 [Qemu-devel] [RFC v2 PATCH 0/6] Live block commit Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images Jeff Cody
2012-09-06 13:23 ` Kevin Wolf
2012-09-06 14:58 ` Eric Blake
2012-09-06 14:59 ` Jeff Cody
2012-09-07 10:19 ` Kevin Wolf
2012-09-07 15:17 ` Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality Jeff Cody
2012-09-06 14:00 ` Kevin Wolf
2012-09-06 20:37 ` Jeff Cody
2012-09-06 21:16 ` Eric Blake
2012-09-07 15:56 ` Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb Jeff Cody
2012-09-07 16:27 ` Paolo Bonzini
2012-09-07 17:04 ` Jeff Cody
2012-09-07 17:09 ` Paolo Bonzini [this message]
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND Jeff Cody
2012-08-30 22:55 ` Eric Blake
2012-08-31 14:42 ` Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 5/6] block: helper function, to find the base image of a chain Jeff Cody
2012-08-30 18:47 ` [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit' Jeff Cody
2012-08-30 23:06 ` Eric Blake
2012-08-31 14:42 ` Jeff Cody
2012-09-06 14:29 ` Kevin Wolf
2012-09-06 21:00 ` Jeff Cody
2012-08-30 21:31 ` [Qemu-devel] [RFC v2 PATCH 0/6] Live block commit Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504A2A4C.2040301@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=supriyak@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).