From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAGkd-0002B4-7J for qemu-devel@nongnu.org; Sat, 08 Sep 2012 04:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAGkc-0000QD-08 for qemu-devel@nongnu.org; Sat, 08 Sep 2012 04:50:51 -0400 Message-ID: <504B06E0.6030100@web.de> Date: Sat, 08 Sep 2012 10:50:40 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <50492BC5.4090107@web.de> <504A0A60.8090507@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig981A5F93B72C7EBD09716AF7" Subject: Re: [Qemu-devel] [PATCH] musicpal: Fix flash mapping List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Peter Maydell , qemu-devel , qemu-stable This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig981A5F93B72C7EBD09716AF7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-09-08 10:44, Blue Swirl wrote: > On Fri, Sep 7, 2012 at 3:25 PM, Peter Maydell wrote: >> On 7 September 2012 15:53, Jan Kiszka wrote: >>> On 2012-09-07 16:41, Peter Maydell wrote: >>>> On 7 September 2012 00:03, Jan Kiszka wrote: >>>>> + pflash_cfi02_register(0x100000000-MP_FLASH_SIZE_MAX, NULL,= >>>> >>>> I don't think this will compile on a 32 bit system, will it? >>>> You probably want an ULL suffix. >>> >>> It does as the result always fits in 32 bits. But I can add that if y= ou >>> prefer. >> >> I think I had a misconception of this bit of the C standard. >> C will pick a type big enough to fit the constant value (which >> will in this case be a 64 bit type of some kind), even without >> an ULL suffix. So you're right, it's OK. >=20 > GCC disagrees: > $ cat u64.c > unsigned int i =3D 0x100000000 - 1; > $ gcc -m32 -Wall -c u64.c > u64.c:1: warning: integer constant is too large for 'long' type Obviously depends on the compiler version or configuration, mine (4.5 still) does not. I'll send v2 to make them all happy. Jan --------------enig981A5F93B72C7EBD09716AF7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBLBuMACgkQitSsb3rl5xQ2QwCfatOYJVt0Ff4zMQjW5iYUuLM5 A1AAn0w5ZSxaShmoETeYwZp667sYwNlE =MR3r -----END PGP SIGNATURE----- --------------enig981A5F93B72C7EBD09716AF7--