From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAIMz-0004HQ-AA for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAIMy-00029H-Cc for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:34:33 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:43169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAIMy-000299-5g for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:34:32 -0400 Received: by wibhm2 with SMTP id hm2so267616wib.10 for ; Sat, 08 Sep 2012 03:34:31 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <504B1F34.7000101@redhat.com> Date: Sat, 08 Sep 2012 12:34:28 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1346917367-24691-1-git-send-email-kraxel@redhat.com> <1346917367-24691-4-git-send-email-kraxel@redhat.com> <50487F59.701@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Peter Maydell , Gerd Hoffmann , qemu-devel@nongnu.org Il 08/09/2012 09:15, Blue Swirl ha scritto: >> Preferably some which don't >> > break on 'qemu -nodefault -device isa-serial,chardev=foo'. > Add a qdev property? The base address check can't be correct, the > serial device could be the only one in the board and wired to wakeup > but still use a different iobase. Could work, but the default value for the property would still be "depending on the iobase". > One way could be to check if chr == serial_hds[0] or rather, pass the > wakeup reason code from board level based on this check. That doesn't work for -device. Paolo