qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more
Date: Sat, 08 Sep 2012 12:37:12 +0200	[thread overview]
Message-ID: <504B1FD8.3030507@redhat.com> (raw)
In-Reply-To: <CAN05THRTecaw9m1UMMaKgiSvSJun76cLtKKHxwxbnFQs5+xwgg@mail.gmail.com>

Il 08/09/2012 01:22, ronnie sahlberg ha scritto:
> Ping?

Both are already in scsi-next, thanks!

Paolo

> On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg
> <ronniesahlberg@gmail.com> wrote:
>> We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> ---
>>  block/iscsi.c |    6 ------
>>  1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c
>> index 0b96165..355ce65 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -167,12 +167,6 @@ iscsi_set_events(IscsiLun *iscsilun)
>>
>>      }
>>
>> -    /* If we just added an event, the callback might be delayed
>> -     * unless we call qemu_notify_event().
>> -     */
>> -    if (ev & ~iscsilun->events) {
>> -        qemu_notify_event();
>> -    }
>>      iscsilun->events = ev;
>>  }
>>
>> --
>> 1.7.3.1
>>
> 
> 

      reply	other threads:[~2012-09-08 10:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 23:56 [Qemu-devel] [PATCH] iSCSI: remove the now obsolete call to qemu_notify_event() Ronnie Sahlberg
2012-08-30 23:56 ` [Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more Ronnie Sahlberg
2012-09-07 23:22   ` ronnie sahlberg
2012-09-08 10:37     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504B1FD8.3030507@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).