From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59845)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TAIPd-0005iN-71
	for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:37:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TAIPc-0003A9-8x
	for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:37:17 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:42503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TAIPc-0003A4-2d
	for qemu-devel@nongnu.org; Sat, 08 Sep 2012 06:37:16 -0400
Received: by wibhm2 with SMTP id hm2so259124wib.10
	for <qemu-devel@nongnu.org>; Sat, 08 Sep 2012 03:37:15 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <504B1FD8.3030507@redhat.com>
Date: Sat, 08 Sep 2012 12:37:12 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1346370996-7691-1-git-send-email-ronniesahlberg@gmail.com>
	<1346370996-7691-2-git-send-email-ronniesahlberg@gmail.com>
	<CAN05THRTecaw9m1UMMaKgiSvSJun76cLtKKHxwxbnFQs5+xwgg@mail.gmail.com>
In-Reply-To: <CAN05THRTecaw9m1UMMaKgiSvSJun76cLtKKHxwxbnFQs5+xwgg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call
 qemu_notify_event() any more
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: qemu-devel@nongnu.org

Il 08/09/2012 01:22, ronnie sahlberg ha scritto:
> Ping?

Both are already in scsi-next, thanks!

Paolo

> On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg
> <ronniesahlberg@gmail.com> wrote:
>> We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> ---
>>  block/iscsi.c |    6 ------
>>  1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c
>> index 0b96165..355ce65 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -167,12 +167,6 @@ iscsi_set_events(IscsiLun *iscsilun)
>>
>>      }
>>
>> -    /* If we just added an event, the callback might be delayed
>> -     * unless we call qemu_notify_event().
>> -     */
>> -    if (ev & ~iscsilun->events) {
>> -        qemu_notify_event();
>> -    }
>>      iscsilun->events = ev;
>>  }
>>
>> --
>> 1.7.3.1
>>
> 
>