[Qemu-devel] [PATCH] iSCSI: remove the now obsolete call to qemu_notify_event()

[Qemu-devel] [PATCH] iSCSI: remove the now obsolete call to qemu_notify_event()

[Ronnie Sahlberg]

Paolo, List

Please find a trivial patch to iscsi that removes the call to qemu_notify_event()
We do not need to call this any more since a recent patch that made
qemu_aio_set_fd_handler() and friends invoke this call automatically when required.

regards
ronnie sahlberg

[Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more

[Ronnie Sahlberg]

We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.

Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
---
 block/iscsi.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index 0b96165..355ce65 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -167,12 +167,6 @@ iscsi_set_events(IscsiLun *iscsilun)
 
     }
 
-    /* If we just added an event, the callback might be delayed
-     * unless we call qemu_notify_event().
-     */
-    if (ev & ~iscsilun->events) {
-        qemu_notify_event();
-    }
     iscsilun->events = ev;
 }
 
-- 
1.7.3.1

Re: [Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more

[ronnie sahlberg]

Ping?

On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg
<ronniesahlberg@gmail.com> wrote:
> We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.
>
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
>  block/iscsi.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 0b96165..355ce65 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -167,12 +167,6 @@ iscsi_set_events(IscsiLun *iscsilun)
>
>      }
>
> -    /* If we just added an event, the callback might be delayed
> -     * unless we call qemu_notify_event().
> -     */
> -    if (ev & ~iscsilun->events) {
> -        qemu_notify_event();
> -    }
>      iscsilun->events = ev;
>  }
>
> --
> 1.7.3.1
>

Re: [Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more

[Paolo Bonzini]

Il 08/09/2012 01:22, ronnie sahlberg ha scritto:
> Ping?

Both are already in scsi-next, thanks!

Paolo

> On Thu, Aug 30, 2012 at 4:56 PM, Ronnie Sahlberg
> <ronniesahlberg@gmail.com> wrote:
>> We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change.
>>
>> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> ---
>>  block/iscsi.c |    6 ------
>>  1 files changed, 0 insertions(+), 6 deletions(-)
>>
>> diff --git a/block/iscsi.c b/block/iscsi.c
>> index 0b96165..355ce65 100644
>> --- a/block/iscsi.c
>> +++ b/block/iscsi.c
>> @@ -167,12 +167,6 @@ iscsi_set_events(IscsiLun *iscsilun)
>>
>>      }
>>
>> -    /* If we just added an event, the callback might be delayed
>> -     * unless we call qemu_notify_event().
>> -     */
>> -    if (ev & ~iscsilun->events) {
>> -        qemu_notify_event();
>> -    }
>>      iscsilun->events = ev;
>>  }
>>
>> --
>> 1.7.3.1
>>
> 
>