qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, "Blue Swirl" <blauwirbel@gmail.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
Date: Sun, 09 Sep 2012 17:13:56 +0300	[thread overview]
Message-ID: <504CA424.5080902@redhat.com> (raw)
In-Reply-To: <5048625F.2060706@siemens.com>

On 09/06/2012 11:44 AM, Jan Kiszka wrote:
> On 2012-08-30 20:30, Jan Kiszka wrote:
>> This adds PCI device assignment for i386 targets using the classic KVM
>> interfaces. This version is 100% identical to what is being maintained
>> in qemu-kvm for several years and is supported by libvirt as well. It is
>> expected to remain relevant for another couple of years until kernels
>> without full-features and performance-wise equivalent VFIO support are
>> obsolete.
>> 
>> A refactoring to-do that should be done in-tree is to model MSI and
>> MSI-X support via the generic PCI layer, similar to what VFIO is already
>> doing for MSI-X. This should improve the correctness and clean up the
>> code from duplicate logic.
>> 
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> 
>> Changes in v3:
>>  - addressed comment by Peter (changed device name to kvm-pci-assign +
>>    alias)
>>  - addressed (most) comments by Michael
>>  - fixed INT pin regression
> 
> Does someone _disagree_ that there are no open (and reasonably solvable)
> issues and that this can now be merged through uq/master?

Is patch 4 the only one that is at v3, and the rest are to be taken from
the original posting?


-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2012-09-09 14:21 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27  6:28 [Qemu-devel] [PATCH 0/4] uq/master: Add classic PCI device assignment Jan Kiszka
2012-08-27  6:28 ` [Qemu-devel] [PATCH 1/4] kvm: Introduce kvm_irqchip_update_msi_route Jan Kiszka
2012-08-27  6:28 ` [Qemu-devel] [PATCH 2/4] kvm: Introduce kvm_has_intx_set_mask Jan Kiszka
2012-08-27  6:28 ` [Qemu-devel] [PATCH 3/4] kvm: i386: Add services required for PCI device assignment Jan Kiszka
2012-08-27  6:28 ` [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic " Jan Kiszka
2012-08-27 12:07   ` Andreas Färber
2012-08-27 12:15     ` Jan Kiszka
2012-08-28 21:26       ` Peter Maydell
2012-08-29  8:47         ` Jan Kiszka
2012-08-29  8:49           ` Peter Maydell
2012-08-29  8:50             ` Jan Kiszka
2012-09-03 15:59             ` Avi Kivity
2012-09-04  3:31               ` Alex Williamson
2012-08-28 12:57     ` Anthony Liguori
2012-08-29 14:08       ` Andreas Färber
2012-08-29 18:32         ` Anthony Liguori
2012-09-04 21:00         ` Anthony Liguori
2012-09-05 15:26           ` Avi Kivity
2012-09-05 15:29             ` Michael S. Tsirkin
2012-09-05 15:41             ` Anthony Liguori
2012-09-05 15:52               ` Avi Kivity
2012-09-05 19:04               ` Blue Swirl
2012-09-05 19:22                 ` Anthony Liguori
2012-09-05 19:38                   ` Blue Swirl
2012-09-05 20:46                     ` Anthony Liguori
2012-09-10 15:33                       ` Andreas Färber
2012-09-06  3:42                     ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-09-08  7:54                       ` Blue Swirl
2012-09-05 19:24                 ` [Qemu-devel] " Eric Blake
2012-09-05 19:43                   ` Blue Swirl
2012-09-06  8:44                 ` Avi Kivity
2012-09-08  8:06                   ` Blue Swirl
2012-09-08  9:28                     ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-09-08 10:16                       ` Blue Swirl
2012-09-08 12:13                         ` Alexander Graf
2012-09-08 12:30                           ` Blue Swirl
2012-09-08 14:59                             ` Alexander Graf
2012-08-27 18:56   ` [Qemu-devel] " Blue Swirl
2012-08-27 19:01     ` Michael S. Tsirkin
2012-08-27 19:06       ` Blue Swirl
2012-08-28  0:30     ` Jan Kiszka
2012-09-03 16:06       ` Avi Kivity
2012-08-28  7:35     ` Michael Tokarev
2012-08-28 17:01       ` Blue Swirl
2012-08-28 17:28         ` Michael S. Tsirkin
2012-08-28 17:38           ` Blue Swirl
2012-08-28 19:31             ` Anthony Liguori
2012-08-28 19:49               ` malc
2012-08-28 20:06               ` Blue Swirl
2012-08-28 21:51                 ` Anthony Liguori
2012-09-01  9:20                   ` Blue Swirl
2012-08-29  8:27               ` Markus Armbruster
2012-09-03 16:14                 ` Avi Kivity
2012-09-03 19:32                   ` Blue Swirl
2012-09-04  8:32                     ` Avi Kivity
2012-09-04 19:27                       ` Blue Swirl
2012-09-04 21:28                         ` Michael S. Tsirkin
2012-09-05 19:09                           ` Blue Swirl
2012-08-28 11:02   ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2012-08-28 21:49     ` Michael S. Tsirkin
2012-08-29  8:44       ` Jan Kiszka
2012-08-29 10:35         ` Michael S. Tsirkin
2012-08-30 18:30     ` [Qemu-devel] [PATCH v3 " Jan Kiszka
2012-09-06  8:44       ` Jan Kiszka
2012-09-06  8:49         ` Michael S. Tsirkin
2012-09-06 16:06         ` Andreas Färber
2012-09-06 16:16           ` Jan Kiszka
2012-09-08  7:55           ` Blue Swirl
2012-09-09 14:13         ` Avi Kivity [this message]
2012-09-10  9:26           ` Jan Kiszka
2012-09-10 12:30             ` Avi Kivity
2012-08-28 15:04   ` [Qemu-devel] [PATCH " Michael S. Tsirkin
2012-08-29 10:50     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504CA424.5080902@redhat.com \
    --to=avi@redhat.com \
    --cc=afaerber@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).