From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAiOI-0001Pu-QZ for qemu-devel@nongnu.org; Sun, 09 Sep 2012 10:21:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAiOH-00065H-R5 for qemu-devel@nongnu.org; Sun, 09 Sep 2012 10:21:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAiOH-00065D-Hi for qemu-devel@nongnu.org; Sun, 09 Sep 2012 10:21:37 -0400 Message-ID: <504CA424.5080902@redhat.com> Date: Sun, 09 Sep 2012 17:13:56 +0300 From: Avi Kivity MIME-Version: 1.0 References: <825e653c9cfe9d8e26185917cbe1f1dd7ae299e2.1346048917.git.jan.kiszka@web.de> <503CA542.7030707@siemens.com> <503FB128.4070709@siemens.com> <5048625F.2060706@siemens.com> In-Reply-To: <5048625F.2060706@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Peter Maydell , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , =?ISO-8859-15?Q?Andreas_F=E4rber?= On 09/06/2012 11:44 AM, Jan Kiszka wrote: > On 2012-08-30 20:30, Jan Kiszka wrote: >> This adds PCI device assignment for i386 targets using the classic KVM >> interfaces. This version is 100% identical to what is being maintained >> in qemu-kvm for several years and is supported by libvirt as well. It is >> expected to remain relevant for another couple of years until kernels >> without full-features and performance-wise equivalent VFIO support are >> obsolete. >> >> A refactoring to-do that should be done in-tree is to model MSI and >> MSI-X support via the generic PCI layer, similar to what VFIO is already >> doing for MSI-X. This should improve the correctness and clean up the >> code from duplicate logic. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Changes in v3: >> - addressed comment by Peter (changed device name to kvm-pci-assign + >> alias) >> - addressed (most) comments by Michael >> - fixed INT pin regression > > Does someone _disagree_ that there are no open (and reasonably solvable) > issues and that this can now be merged through uq/master? Is patch 4 the only one that is at v3, and the rest are to be taken from the original posting? -- error compiling committee.c: too many arguments to function