From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAwqd-00084l-QT for qemu-devel@nongnu.org; Mon, 10 Sep 2012 01:47:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TAwqc-0001TY-Mi for qemu-devel@nongnu.org; Mon, 10 Sep 2012 01:47:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TAwqc-0001TS-EN for qemu-devel@nongnu.org; Mon, 10 Sep 2012 01:47:50 -0400 Message-ID: <504D7EFF.7070307@redhat.com> Date: Mon, 10 Sep 2012 07:47:43 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1346917367-24691-1-git-send-email-kraxel@redhat.com> <1346917367-24691-4-git-send-email-kraxel@redhat.com> <50487F59.701@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] wakeup: make serial configurable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Peter Maydell , qemu-devel@nongnu.org Hi, >>> It seems a bit odd that this is done in the ISA serial model >>> itself and not by the next level up wiring up some output >>> of the ISA serial device to some appropriate input... >> >> Suggestions how to do that are welcome. Preferably some which don't >> break on 'qemu -nodefault -device isa-serial,chardev=foo'. > > Add a qdev property? And offload it to the user / management tool to get that correct? Don't think this is a good idea. > The base address check can't be correct, the > serial device could be the only one in the board and wired to wakeup > but still use a different iobase. We might want to add a check for TARGET_I386, but for x86 it actually _is_ correct as this matches the acpi dsdt information. > One way could be to check if chr == serial_hds[0] or rather, pass the > wakeup reason code from board level based on this check. Wouldn't work. cheers, Gerd