From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Søren Sandmann" <ssp@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qxl: Ignore set_client_capabilities pre/post migrate
Date: Mon, 10 Sep 2012 10:50:24 +0200 [thread overview]
Message-ID: <504DA9D0.6000002@redhat.com> (raw)
In-Reply-To: <1347047302-8133-1-git-send-email-hdegoede@redhat.com>
On 09/07/12 21:48, Hans de Goede wrote:
> The recent introduction of set_client_capabilities has broken
> (seamless) migration by trying to call qxl_send_events pre (seamless
> incoming) and post (*) migration, triggering the following assert:
> qxl_send_events: Assertion `qemu_spice_display_is_running(&d->ssd)' failed.
>
> The solution is easy, pre migration the guest will have already received
> the client caps on the migration source side, and post migration there no
> longer is a guest, so we can simply ignore the set_client_capabilities call
> in both those scenarios.
Patch added to spice patch queue.
thanks,
Gerd
prev parent reply other threads:[~2012-09-10 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 19:48 [Qemu-devel] [PATCH] qxl: Ignore set_client_capabilities pre/post migrate Hans de Goede
2012-09-10 8:50 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DA9D0.6000002@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ssp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).