From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48597)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TAzhN-0003o1-Oe
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 04:50:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TAzhM-0006Tq-Fd
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 04:50:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47038)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TAzhM-0006Ti-70
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 04:50:28 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8A8oRv2031554
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 10 Sep 2012 04:50:27 -0400
Message-ID: <504DA9D0.6000002@redhat.com>
Date: Mon, 10 Sep 2012 10:50:24 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1347047302-8133-1-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1347047302-8133-1-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qxl: Ignore set_client_capabilities
	pre/post migrate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: =?ISO-8859-1?Q?S=F8ren_Sandmann?= <ssp@redhat.com>, qemu-devel@nongnu.org

On 09/07/12 21:48, Hans de Goede wrote:
> The recent introduction of set_client_capabilities has broken
> (seamless) migration by trying to call qxl_send_events pre (seamless
> incoming) and post (*) migration, triggering the following assert:
> qxl_send_events: Assertion `qemu_spice_display_is_running(&d->ssd)' failed.
> 
> The solution is easy, pre migration the guest will have already received
> the client caps on the migration source side, and post migration there no
> longer is a guest, so we can simply ignore the set_client_capabilities call
> in both those scenarios.

Patch added to spice patch queue.

thanks,
  Gerd