From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TB1Ts-0008CL-TH
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 06:44:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TB1Tm-00008x-TL
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 06:44:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2235)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TB1Tm-00008s-JI
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 06:44:34 -0400
Message-ID: <504DC488.8080307@redhat.com>
Date: Mon, 10 Sep 2012 13:44:24 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1346770981.git.julien.grall@citrix.com>
	<767c2d0e1f86cd99872eb51f9545eebc7f27411e.1346770982.git.julien.grall@citrix.com>
	<504CA638.1030800@redhat.com> <504DC2DF.5030705@citrix.com>
In-Reply-To: <504DC2DF.5030705@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V9 4/8] hw/acpi_piix4.c: replace
	register_ioport*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Julien Grall <julien.grall@citrix.com>
Cc: "jan.kiszka@siemens.com" <jan.kiszka@siemens.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "afaerber@suse.de" <afaerber@suse.de>, "kraxel@redhat.com" <kraxel@redhat.com>

On 09/10/2012 01:37 PM, Julien Grall wrote:
> On 09/09/2012 03:22 PM, Avi Kivity wrote:
>> On 09/04/2012 06:13 PM, Julien Grall wrote:
>>   
>>> This patch replaces all register_ioport* with the new memory API. It
>>> permits
>>> to use the new Memory stuff like listener.
>>>
>>>      
>>   
>>> @@ -200,8 +212,11 @@ static void pm_io_space_update(PIIX4PMState *s)
>>>
>>>           /* XXX: need to improve memory and ioport allocation */
>>>           PIIX4_DPRINTF("PM: mapping to 0x%x\n", pm_io_base);
>>> -        iorange_init(&s->ioport,&pm_iorange_ops, pm_io_base, 64);
>>> -        ioport_register(&s->ioport);
>>> +
>>> +        memory_region_set_address(&s->pm_io, pm_io_base);
>>> +        memory_region_set_enabled(&s->pm_io, true);
>>> +    } else {
>>> +        memory_region_set_enabled(&s->pm_io, false);
>>>       }
>>>   }
>>>
>>>      
>> The entire if () can be simplified to
>>
>>         pm_io_base = le32_to_cpu(*(uint32_t *)(s->dev.config + 0x40));
>>         pm_io_base&= 0xffc0;
>>         memory_region_transaction_begin()
>>         memory_region_set_enabled(&s->pm_io, s->dev.config[0x80]&  1);
>>         memory_region_set_address(&s->pm_io, pm_io_base);
>>         memory_region_transaction_commit();
>>    
> I will modify, do I need to resend all the patch series or just this
> patch ?
> 

Just this patch would be fine.

-- 
error compiling committee.c: too many arguments to function