From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB5Eh-00028F-6V for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:45:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TB5EZ-0002OF-Vm for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:45:15 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:57203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB5EZ-0002N9-PG for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:45:07 -0400 Received: by pbbrp12 with SMTP id rp12so1355068pbb.4 for ; Mon, 10 Sep 2012 07:45:07 -0700 (PDT) Sender: Richard Henderson Message-ID: <504DFCF0.7040109@twiddle.net> Date: Mon, 10 Sep 2012 07:45:04 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1347224784-19472-1-git-send-email-rth@twiddle.net> <1347224784-19472-8-git-send-email-rth@twiddle.net> <20120910143422.GZ6791@ohm.aurel32.net> In-Reply-To: <20120910143422.GZ6791@ohm.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org, Alexander Graf On 09/10/2012 07:34 AM, Aurelien Jarno wrote: > If it is not possible to implement your FPR code using these functions, > we might want to add some more, but I really thing it's a bad idea to > have this code in the targets. I thought I got rid of all this in the various rebasing. Certainly it's all gone by the end of the patch series. In particular, the optimization that I was looking for is handled inside tcg_gen_deposit_i64, so there's no point in doing this in target code too. I'll make sure this is gone from the next revision. r~