From: Eric Blake <eblake@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 2/6] libqblock type and structure defines
Date: Mon, 10 Sep 2012 22:12:47 -0600 [thread overview]
Message-ID: <504EBA3F.9010506@redhat.com> (raw)
In-Reply-To: <504EAF55.7020802@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On 09/10/2012 09:26 PM, Wenchao Xia wrote:
>>> +#define QB_ERR_STRING_SIZE (1024)
>>> +struct QBroker {
>>> + /* last error */
>>> + char err_msg[QB_ERR_STRING_SIZE];
>>
>> Is this fixed-width struct going to bite us in the future? Suppose I
>> pass in a file name that is already 1000 bytes long; it seems like I
>> might be able to get you to overflow this buffer if your error message
>> includes the name of my offending file.
>>
> Yes it will, thanks for mention me. The resource will always have a
> limit, I guess I can just increase the size to 4k to solve the issue.
A 4k limit is still an easily reachable limit. PATH_MAX is typically
4k, and it is quite possible to create and access files in a hierarchy
so deep that they are longer than PATH_MAX. I still think you are
better off malloc'ing a pointer than trying to claim a fixed width field
solves all possible messages.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-09-11 4:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 8:26 [Qemu-devel] [PATCH V2 0/6] libqblock, qemu block layer library Wenchao Xia
2012-09-10 8:26 ` [Qemu-devel] [PATCH V2 1/6] libqblock API design Wenchao Xia
2012-09-10 21:07 ` Eric Blake
2012-09-11 3:16 ` Wenchao Xia
2012-09-14 2:03 ` Wenchao Xia
2012-09-11 20:28 ` Blue Swirl
2012-09-12 2:54 ` Wenchao Xia
2012-09-12 8:19 ` Kevin Wolf
2012-09-12 9:21 ` Wenchao Xia
2012-09-14 19:08 ` Blue Swirl
2012-09-10 8:26 ` [Qemu-devel] [PATCH V2 2/6] libqblock type and structure defines Wenchao Xia
2012-09-10 21:27 ` Eric Blake
2012-09-11 3:26 ` Wenchao Xia
2012-09-11 4:12 ` Eric Blake [this message]
2012-09-11 20:31 ` Blue Swirl
2012-09-11 22:52 ` Eric Blake
2012-09-12 3:05 ` Wenchao Xia
2012-09-12 12:59 ` Eric Blake
2012-09-13 3:24 ` Wenchao Xia
2012-09-13 3:33 ` Eric Blake
2012-09-13 3:49 ` Eric Blake
2012-09-14 18:11 ` Blue Swirl
2012-09-17 2:23 ` Wenchao Xia
2012-09-17 19:08 ` Blue Swirl
2012-09-14 18:02 ` Blue Swirl
2012-09-10 8:26 ` [Qemu-devel] [PATCH V2 3/6] libqblock error handling Wenchao Xia
2012-09-10 21:33 ` Eric Blake
2012-09-11 4:36 ` Wenchao Xia
2012-09-11 20:32 ` Blue Swirl
2012-09-12 2:58 ` Wenchao Xia
2012-09-14 17:09 ` Blue Swirl
2012-09-10 8:26 ` [Qemu-devel] [PATCH V2 4/6] libqblock export some qemu block function Wenchao Xia
2012-09-10 8:26 ` [Qemu-devel] [PATCH V2 5/6] libqblock building system Wenchao Xia
2012-09-10 8:26 ` [Qemu-devel] [PATCH V2 6/6] libqblock test example Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504EBA3F.9010506@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).