From: Paolo Bonzini <pbonzini@redhat.com>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: Stefan Weil <sw@weilnetz.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] buildbot failure in qemu on default_mingw32
Date: Tue, 11 Sep 2012 09:07:01 +0200 [thread overview]
Message-ID: <504EE315.7010401@redhat.com> (raw)
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E2517A1@SHSMSX101.ccr.corp.intel.com>
Il 11/09/2012 09:05, Zhang, Yang Z ha scritto:
> how about the following patch:
>
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index d63554f..30bbbe6 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -556,14 +556,14 @@ static void rtc_set_cmos(RTCState *s, const struct tm *tm)
>
> static void rtc_update_time(RTCState *s)
> {
> - struct tm ret;
> + struct tm *ret;
> time_t guest_sec;
> int64_t guest_nsec;
>
> guest_nsec = get_guest_rtc_ns(s);
> guest_sec = guest_nsec / NSEC_PER_SEC;
> - gmtime_r(&guest_sec, &ret);
> - rtc_set_cmos(s, &ret);
> + ret = gmtime(&guest_sec);
> + rtc_set_cmos(s, ret);
> }
No, let's add a portability wrapper for gmtime_r instead.
Paolo
next prev parent reply other threads:[~2012-09-11 7:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 23:54 [Qemu-devel] buildbot failure in qemu on default_mingw32 qemu
2012-09-11 5:14 ` Stefan Weil
2012-09-11 5:23 ` Stefan Weil
2012-09-11 6:57 ` Paolo Bonzini
2012-09-11 7:05 ` Zhang, Yang Z
2012-09-11 7:07 ` Paolo Bonzini [this message]
2012-09-11 7:15 ` Zhang, Yang Z
-- strict thread matches above, loose matches on Subject: below --
2013-01-18 22:27 qemu
2013-01-14 22:23 qemu
2013-01-03 22:51 qemu
2012-11-16 22:48 qemu
2012-11-17 7:28 ` Stefan Weil
2012-11-03 1:11 qemu
2012-11-03 6:08 ` Stefan Hajnoczi
2012-11-03 9:24 ` Daniel Gollub
2012-11-03 14:35 ` Stefan Hajnoczi
2012-10-30 0:53 qemu
2012-10-30 8:03 ` Paolo Bonzini
2012-10-30 14:05 ` Michael S. Tsirkin
2012-10-05 23:51 qemu
2012-10-08 6:07 ` Stefan Hajnoczi
2012-09-06 0:06 qemu
2012-09-06 0:22 ` Max Filippov
2012-08-14 23:32 qemu
2012-08-06 23:26 qemu
2012-08-03 23:29 qemu
2012-07-19 23:18 qemu
2012-07-17 23:10 qemu
2012-07-09 23:47 qemu
2012-03-15 0:32 qemu
2012-03-01 0:36 qemu
2012-03-01 0:35 ` Roy Tam
2012-02-04 0:11 qemu
2012-02-03 23:43 ` Anthony Liguori
2012-02-04 8:29 ` Stefan Weil
2012-02-06 20:27 ` Corey Bryant
2012-02-07 10:28 ` Stefan Hajnoczi
2012-02-07 14:32 ` Corey Bryant
2012-02-07 14:59 ` Stefan Hajnoczi
2012-02-07 15:10 ` Corey Bryant
2011-12-13 1:02 qemu
2011-12-13 6:33 ` Paolo Bonzini
2011-10-03 23:29 qemu
2011-09-30 23:06 qemu
2011-09-20 23:28 qemu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504EE315.7010401@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).