From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TBKYy-000258-Vi
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:07:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TBKYt-000202-5t
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:07:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55704)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TBKYs-0001zy-U1
	for qemu-devel@nongnu.org; Tue, 11 Sep 2012 03:07:07 -0400
Message-ID: <504EE315.7010401@redhat.com>
Date: Tue, 11 Sep 2012 09:07:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20120910235402.7060E41136@buildbot.b1-systems.de>
	<504EC8A8.4070501@weilnetz.de>
	<A9667DDFB95DB7438FA9D7D576C3D87E2517A1@SHSMSX101.ccr.corp.intel.com>
In-Reply-To: <A9667DDFB95DB7438FA9D7D576C3D87E2517A1@SHSMSX101.ccr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] buildbot failure in qemu on default_mingw32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: Stefan Weil <sw@weilnetz.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Il 11/09/2012 09:05, Zhang, Yang Z ha scritto:
> how about the following patch:
> 
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index d63554f..30bbbe6 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -556,14 +556,14 @@ static void rtc_set_cmos(RTCState *s, const struct tm *tm)
> 
>  static void rtc_update_time(RTCState *s)
>  {
> -    struct tm ret;
> +    struct tm *ret;
>      time_t guest_sec;
>      int64_t guest_nsec;
> 
>      guest_nsec = get_guest_rtc_ns(s);
>      guest_sec = guest_nsec / NSEC_PER_SEC;
> -    gmtime_r(&guest_sec, &ret);
> -    rtc_set_cmos(s, &ret);
> +    ret = gmtime(&guest_sec);
> +    rtc_set_cmos(s, ret);
>  }

No, let's add a portability wrapper for gmtime_r instead.

Paolo