From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBPO1-0003f4-Uf for qemu-devel@nongnu.org; Tue, 11 Sep 2012 08:16:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBPNZ-000870-Mi for qemu-devel@nongnu.org; Tue, 11 Sep 2012 08:16:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBPNZ-00086Y-3M for qemu-devel@nongnu.org; Tue, 11 Sep 2012 08:15:45 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8BCFh2K030023 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Sep 2012 08:15:43 -0400 Message-ID: <504F2BB7.1060509@redhat.com> Date: Tue, 11 Sep 2012 14:16:55 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1325808533.33053564.1347365025414.JavaMail.root@redhat.com> In-Reply-To: <1325808533.33053564.1347365025414.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] hw/qxl: support client monitor configuration via device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org, Gerd Hoffmann Hi, On 09/11/2012 02:03 PM, Alon Levy wrote: >> Hi, >> >> Sorry for top posting, but trying to summarize this thread here. >> >> I must say I like Gerd's approach, as it unifies code paths mostly, >> instead of having yet another interface where we do 2 way >> capabilities >> negotiation, with all the extra test matrix entries that would entice >> for full testing, we keep things simple. > > So you are suggesting to send the message to both parties, and ignore it in the guest agent if it sees a qxl device. No, slightly more sophisticated, what I'm suggesting is that the server will not forward the VDAgentMonitorsConfig to the agent, if the qxl-dev's int_mask contains QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. This should work because either we have a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG aware driver, ie the new kms driver and it sets QXL_INTERRUPT_CLIENT_MONITORS_CONFIG in int_mask, or we don't and then the right thing to do is send the message to the agent to deal with it. This will need spice-server <-> qemu/hw/qxl.c coordination, but I assume we will need some changes there anyway to set QXL_INTERRUPT_CLIENT_MONITORS_CONFIG, the qemu/hw/qxl.c function patching the MonitorsConfig into the romspace, and setting the irq in int_pending, could return whether or not the flag was set in int_mask for example. Regards, Hans