From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBQCK-0000PL-5P for qemu-devel@nongnu.org; Tue, 11 Sep 2012 09:08:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBQCE-0000RM-F2 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 09:08:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBQCE-0000R9-6O for qemu-devel@nongnu.org; Tue, 11 Sep 2012 09:08:06 -0400 Message-ID: <504F3779.2090407@redhat.com> Date: Tue, 11 Sep 2012 15:07:05 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-20-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343127865-16608-20-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 24.07.2012 13:03, schrieb Paolo Bonzini: > Extract it out of the implementation of "info block". > > Signed-off-by: Paolo Bonzini > --- > block.c | 104 +++++++++++++++++++++++++++++++-------------------------------- > block.h | 1 + > 2 files changed, 53 insertions(+), 52 deletions(-) The refactoring looks correct, but why do you put the function between qmp_query_blockstat and qmp_query_blockstats? If you put it next to qmp_query_block, both functions pairs stay closer together. Kevin