From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBR3H-00038y-W0 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:03:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBR3A-0002tU-4W for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:02:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBR39-0002tH-SE for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:02:48 -0400 Message-ID: <504F447E.6000303@redhat.com> Date: Tue, 11 Sep 2012 16:02:38 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <945284147.67734523.1347371399653.JavaMail.root@redhat.com> In-Reply-To: <945284147.67734523.1347371399653.JavaMail.root@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 22/47] block: make device optional in BlockInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 11.09.2012 15:49, schrieb Paolo Bonzini: >=20 >=20 > ----- Messaggio originale ----- >> Da: "Kevin Wolf" >> A: "Paolo Bonzini" >> Cc: qemu-devel@nongnu.org, eblake@redhat.com, jcody@redhat.com, stefan= ha@linux.vnet.ibm.com >> Inviato: Marted=C3=AC, 11 settembre 2012 15:38:33 >> Oggetto: Re: [PATCH 22/47] block: make device optional in BlockInfo >> >> Am 24.07.2012 13:04, schrieb Paolo Bonzini: >>> Targets of a mirroring operation will not have a device. Once we >>> have >>> -blockdev or equivalent, "detached" block devices and non-anonymous >>> backing files also will not have a device. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> qapi-schema.json | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/qapi-schema.json b/qapi-schema.json >>> index fca1806..b00d8c6 100644 >>> --- a/qapi-schema.json >>> +++ b/qapi-schema.json >>> @@ -443,7 +443,8 @@ >>> # Block device information. This structure describes a virtual >>> device and >>> # the backing device associated with it. >>> # >>> -# @device: The device name associated with the virtual device. >>> +# @device: #optional The device name associated with the virtual >>> device. >>> +# Always included in the output of query-block. >>> # >>> # @type: This field is returned only for compatibility reasons, it >>> should >>> # not be used (always returns 'unknown') >>> @@ -465,7 +466,7 @@ >>> # Since: 0.14.0 >>> ## >>> { 'type': 'BlockInfo', >>> - 'data': {'device': 'str', 'type': 'str', 'removable': 'bool', >>> + 'data': {'*device': 'str', 'type': 'str', 'removable': 'bool', >>> 'locked': 'bool', '*inserted': 'BlockDeviceInfo', >>> '*tray_open': 'bool', '*io-status': >>> 'BlockDeviceIoStatus'} } >> >> Is this really a compatible change? That 'device' is basically the >> unique key by which block device are identified doesn't exactly make >> feel more comfortable about the change. >=20 > As long as query-block ensures that the field is present---yes. >=20 >> Of course, not making it optional means that basically we need to go >> the way of referencing the block device in query-block-jobs immediatel= y >> instead of thinking about it later. You know that I preferred this >> from the start, and this change is just another detail that makes me t= hink >> it's the right thing to do. >=20 > Indeed; this patch is not anymore in the current version of the series, > after your comments from July/August. Wait, am I reviewing the wrong version of the series? :-/ Did you post a newer one? Kevin