From: Don Slutz <Don@CloudSwitch.Com>
To: Don Slutz <Don@CloudSwitch.com>
Cc: blauwirbel@gmail.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().
Date: Tue, 11 Sep 2012 10:13:49 -0400 [thread overview]
Message-ID: <504F471D.3030701@CloudSwitch.Com> (raw)
In-Reply-To: <1346630960-30887-1-git-send-email-Don@CloudSwitch.com>
On 09/02/12 20:09, Don Slutz wrote:
> Send it to stderr before free of the details.
>
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
> ---
> v2: Change __FUNCTION__ to __func__
>
> target-i386/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 57c064f..760cca4 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
> }
> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
> if (error_is_set(&error)) {
> + fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
> error_free(error);
> return -1;
> }
The (3) patch set in
http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg01400.html
includes this change, and so this request is being withdrawn.
next prev parent reply other threads:[~2012-09-11 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 20:47 [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register() Don Slutz
2012-09-02 10:54 ` Blue Swirl
2012-09-02 23:40 ` Don Slutz
2012-09-03 0:09 ` [Qemu-devel] [PATCH v2] " Don Slutz
2012-09-11 14:13 ` Don Slutz [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-17 14:00 Don Slutz
2012-09-17 14:02 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F471D.3030701@CloudSwitch.Com \
--to=don@cloudswitch.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).