From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRtw-00067K-6x for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:57:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBRtl-0005TH-Rt for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:57:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBRtl-0005TB-Ie for qemu-devel@nongnu.org; Tue, 11 Sep 2012 10:57:09 -0400 Message-ID: <504F513F.2040006@redhat.com> Date: Tue, 11 Sep 2012 16:57:03 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-25-git-send-email-pbonzini@redhat.com> In-Reply-To: <1343127865-16608-25-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 24/47] block: introduce new dirty bitmap functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 24.07.2012 13:04, schrieb Paolo Bonzini: > Assert that write_compressed is never used with the dirty bitmap. > Setting the bits early is wrong, because a coroutine might concurrently > examine them and copy incomplete data from the source. > > Signed-off-by: Paolo Bonzini Looks good, but I think it should be documented at least that bdrv_get_next_dirty() hangs when it's called and there is no dirty block. Kevin